[GitHub] [hbase] anoopsjohn commented on a change in pull request #3347: HBASE-25955 Setting NAMESPACES when adding a replication peer doesn't…

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #3347:
URL: https://github.com/apache/hbase/pull/3347#discussion_r643887997



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java
##########
@@ -69,13 +68,14 @@ public void peerConfigUpdated(ReplicationPeerConfig rpc){
   @Override
   public WALEntryFilter getWALEntryfilter() {
     ArrayList<WALEntryFilter> filters = Lists.newArrayList();
-    WALEntryFilter scopeFilter = getScopeWALEntryFilter();
-    if (scopeFilter != null) {
-      filters.add(scopeFilter);
-    }
     WALEntryFilter tableCfFilter = getNamespaceTableCfWALEntryFilter();
     if (tableCfFilter != null) {
       filters.add(tableCfFilter);
+    } else {

Review comment:
       This means when any of the wildcard kind of setting (like one NS for include) is present, a per table:cf setting wont get honoured?
   To be specific say we have 2 NS, ns1 and ns2.    Now ns1 is in the include NS list.  So all tables in ns1 to be replicated. Thats it. ns2 is neither in include list nor in exclude list.  But ns2 having one table with CFs of replication scope = 1. But as per this change we will not consider those tables for replication as scopeFilter wont come in then? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org