You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/20 16:46:31 UTC

[GitHub] [avro] KyleSchoonover opened a new pull request #1467: AVRO-3314 Updated exception thrown by IConvertable.ToType

KyleSchoonover opened a new pull request #1467:
URL: https://github.com/apache/avro/pull/1467


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [[Avro Jira](https://issues.apache.org/jira/browse/AVRO/](https://issues.apache.org/jira/browse/AVRO-3314)) issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AVRO-3314
   
   ### Tests
   
   - [ ] My PR does not need testing for this extremely good reason: This is a throw exception change.  Not a logic change.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - Documentation updated in code
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g commented on pull request #1467: AVRO-3314: Updated exception thrown by IConvertable.ToType

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1467:
URL: https://github.com/apache/avro/pull/1467#issuecomment-1019853556


   > There are a lot of updates I want to do, but starting slow.
   
   Thank you for offering your help, @KyleSchoonover !
   There are several open [PRs](https://github.com/apache/avro/pulls?q=is%3Aopen+is%3Apr+label%3AC%23) for which we would love to get some reviews from C# developers! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] KyleSchoonover commented on pull request #1467: AVRO-3314: Updated exception thrown by IConvertable.ToType

Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1467:
URL: https://github.com/apache/avro/pull/1467#issuecomment-1018705865


   > 
   
   That is an excellent question.  I'm starting small with just following some .NET (C#) coding standards.  There are a lot of updates I want to do, but starting slow.  If there are any conversation about styling or which standards we definitely want to adhere to, I would love to be involved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g merged pull request #1467: AVRO-3314: Updated exception thrown by IConvertable.ToType

Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1467:
URL: https://github.com/apache/avro/pull/1467


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org