You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Bryan Pendleton (JIRA)" <ji...@apache.org> on 2010/11/11 16:06:15 UTC
[jira] Commented: (DERBY-4899) Refactor access to primary
structures in AlterTableConstantAction
[ https://issues.apache.org/jira/browse/DERBY-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931033#action_12931033 ]
Bryan Pendleton commented on DERBY-4899:
----------------------------------------
+1 to simplifying and removing unnecessary code!
> Refactor access to primary structures in AlterTableConstantAction
> -----------------------------------------------------------------
>
> Key: DERBY-4899
> URL: https://issues.apache.org/jira/browse/DERBY-4899
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.7.1.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-4899-1a-cleanup.diff
>
>
> Many of the private methods in impl.sql.execute.AlterTableConstantAction take the activation (and sometimes a number of references obtained through it) as an argument. This seems unnecessary, and it clutters the code with argument passing, boilerplate code and variable hiding.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.