You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Harry Metske (JIRA)" <ji...@apache.org> on 2009/05/09 18:40:46 UTC

[jira] Commented: (JSPWIKI-528) Rationalise the use of Collections, particularly with regard to pages

    [ https://issues.apache.org/jira/browse/JSPWIKI-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707689#action_12707689 ] 

Harry Metske commented on JSPWIKI-528:
--------------------------------------

Applied  jspwiki-528-Weblog.patch and jspwiki-528-workflow.Step.patch.

The remaining patches don't fit anymore, mostly because Andrew's patches from the last two weeks already changed a lot of Collections into Lists.
Could you check what is still missing now ?

Harry

> Rationalise the use of Collections, particularly with regard to pages
> ---------------------------------------------------------------------
>
>                 Key: JSPWIKI-528
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-528
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Greg Kable
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: jspwiki-528-AbstractFilteredPlugin.patch, jspwiki-528-AttachmentHandler.patch, jspwiki-528-ContentManager.patch, jspwiki-528-LinkCollector.patch, jspwiki-528-SearchProviders.patch, jspwiki-528-Weblog.patch, jspwiki-528-WikiEngine-771034.patch, jspwiki-528-WikiEngine.patch, jspwiki-528-WikiPage.patch, jspwiki-528-workflow.Step.patch
>
>
> Most of the APIs return Collection rather than a finer interface and in many cases these collections are repeatedly repacked and resorted unnecessarily. I will go through all APIs that return collections of pages and make them return a finer interface - probably List for unordered collections and SortedSet for ordered collections. This will make the use of these collections much clearer for further development and give us some opportunity for future optimisations.
> This is likely to be a very wide set of changes across lots of different classes so I'll submit separate patches for each class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.