You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Bojan Smojver <bo...@binarix.com> on 2001/09/24 23:21:46 UTC

[PATCH]: TC 3.3 ReloadInterceptor: Local Interceptors -> Feedback wanted

This seems to do the trick. I've tested it with the JDBCRealm
interceptor and it behaves normally (ie. JDBCRealm gets hooked back in
and it actually works after the application reload).

Any feedback before this gets committed is welcome (as in: I'd rather
not screw up TC 3.3 RC with my first commit :-)

Bojan

Re: [PATCH]: TC 3.3 ReloadInterceptor: Local Interceptors -> Feedbackwanted

Posted by cm...@yahoo.com.
On Tue, 25 Sep 2001, Bojan Smojver wrote:

> cmanolache@yahoo.com wrote:
> >
> > Hi Bojan,
> >
> > +1 - looks very good, it'll be a great 'first commit'.
> >
> > ( 'normal' case with only global modules is not affected in any way, and
> > for local modules it'll do the right thing, and update the context ).
>
> Thanks. Wouldn't be able to do any of it without your guidance.

Well, you were right in the first place - we need a mechanism to detect
changes in the config and reconfigure, taking into account the new
app-foo.xml file. And your initial solutions is probably better -
and could solve part of the 'reconfigure' issue.

Maybe later ( after 3.3 ) we could revisit this issue and improve a bit
ContextXmlReader.

Costin

Re: [PATCH]: TC 3.3 ReloadInterceptor: Local Interceptors -> Feedbackwanted

Posted by Bojan Smojver <bo...@binarix.com>.
cmanolache@yahoo.com wrote:
> 
> Hi Bojan,
> 
> +1 - looks very good, it'll be a great 'first commit'.
> 
> ( 'normal' case with only global modules is not affected in any way, and
> for local modules it'll do the right thing, and update the context ).

Thanks. Wouldn't be able to do any of it without your guidance.

Bojan

Re: [PATCH]: TC 3.3 ReloadInterceptor: Local Interceptors -> Feedback wanted

Posted by cm...@yahoo.com.
Hi Bojan,

+1 - looks very good, it'll be a great 'first commit'.

( 'normal' case with only global modules is not affected in any way, and
for local modules it'll do the right thing, and update the context ).

Costin


On Tue, 25 Sep 2001, Bojan Smojver wrote:

> This seems to do the trick. I've tested it with the JDBCRealm
> interceptor and it behaves normally (ie. JDBCRealm gets hooked back in
> and it actually works after the application reload).
>
> Any feedback before this gets committed is welcome (as in: I'd rather
> not screw up TC 3.3 RC with my first commit :-)
>
> Bojan