You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Eric Norman (Jira)" <ji...@apache.org> on 2021/06/03 23:37:00 UTC

[jira] [Comment Edited] (SLING-10040) review and resolve code quality warnings and issues reported by sonar

    [ https://issues.apache.org/jira/browse/SLING-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356979#comment-17356979 ] 

Eric Norman edited comment on SLING-10040 at 6/3/21, 11:36 PM:
---------------------------------------------------------------

Marking this as resolved 

Currently sonar reports 25 issues of which I reviewed as:
 * 3 are warnings about removing deprecated code at some point
 * 9 are warnings about reducing cognitive complexity which can maybe be considered later
 * 7 are warnings about classes with too many parents which we shouldn't do anything about
 * 6 are warnings about code duplication that appear to be false positives related to the fact that the osgi component annotations are not inherited so those common parts can not be moved to the super class.

 

25 Issues
 0 Bugs
 0 Vulnerabilities
 0 Security Hotspots
 25 Code Smells


was (Author: enorman):
Marking this as resolved 

Currently sonar reports 25 issues of which I reviewed as:
 * 3 are warnings about removing deprecated code at some point
 * 9 arewarnings about reducing cognitive complexity which can maybe be considered later
 * 7 are warnings about classes with too many parents which we shouldn't do anything about
 * 6 are warnings about code duplication that appear to be false positives related to the fact that the osgi component annotations are not inherited so those common parts can not be moved to the super class.

 

25 Issues
0 Bugs
0 Vulnerabilities
0 Security Hotspots
25 Code Smells

> review and resolve code quality warnings and issues reported by sonar
> ---------------------------------------------------------------------
>
>                 Key: SLING-10040
>                 URL: https://issues.apache.org/jira/browse/SLING-10040
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Eric Norman
>            Assignee: Eric Norman
>            Priority: Minor
>             Fix For: JCR Jackrabbit User Manager 2.2.14
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently sonar reports 119 Issues in the project:
>  0 Bugs
>  2 Vulnerabilities
>  0 Security Hotspots
>  117 Code Smells



--
This message was sent by Atlassian Jira
(v8.3.4#803005)