[GitHub] [tinkerpop] giovibal commented on pull request #1380: Use a List of strategies instead of Set

[GitBox <gi...@apache.org>]

giovibal commented on pull request #1380:
URL: https://github.com/apache/tinkerpop/pull/1380#issuecomment-762914001


   Thank you for your explanation.
   
   For me is more coerent if there is a list of strategies, evaluated in order. For a client perspective, if I pass a List, I expect a List. Othewise must be -at least- an exception during configuration of strategies.
   
   If we can't use 2 PartitionStrategy classes, can extend PartitionStrategy (inside a gremlin plugin) and use a different class-name to circumvent the problem ? 
   
   ### Our use-case
   
   We use gremlin server with 2 levels of partition strategies: one level to divide config from management data, and inside config we have a partition by tenant.
   Since 2015 we are in production with this model and everything works fine.
   When we upgraded gremlin from 3.3.4 to v3.4.9, nothing worked anymore for us, and we noticed this change change from List to Set ( 67ddf587a06c2ab27d27c51c659f98116c3ab753 ).
   For us this is a breaking change, we need to mantain ad internal fork to release the next version.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org