[jira] [Comment Edited] (TS-1627) Support GET requests with payload

["Uri Shachar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533388#comment-13533388 ] 

Uri Shachar edited comment on TS-1627 at 12/16/12 1:22 PM:
-----------------------------------------------------------

The proposed patch only fixes the problem for requests with a Content-Length header. GET requests with "Transfer-Encoding: chunked" will still be stripped of payload. 
Fixing this isn't very complicated, but will make the code uglier -- I don't think it's worth it....

Also -- The change to HttpTransact::check_request_validity isn't really necessary, but it removes a redundant check (I had a change there and then noticed it wasn't needed).
                
      was (Author: ushachar):
    The proposed patch only fixes the problem for requests with a Content-Length header. GET requests with "Transfer-Encoding: chunked" will still be stripped of payload. 
Fixing this isn't very complicated, but will make the code uglier -- I don't think it's worth it....
                  
> Support GET requests with payload
> ---------------------------------
>
>                 Key: TS-1627
>                 URL: https://issues.apache.org/jira/browse/TS-1627
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>    Affects Versions: 3.3.0
>            Reporter: Uri Shachar
>         Attachments: get_with_payload.patch
>
>
> From what I understand from RFC 2616, these requests should be legal. ATS currently accepts these requests, but drops the body when passing them onward to the upstream.
> Most discussion that I could find on the web say that this is legal -- although what the upstream can actually do with the payload isn't clear....
> http://lists.w3.org/Archives/Public/ietf-http-wg/2006AprJun/0096.html
> http://tech.groups.yahoo.com/group/rest-discuss/message/9957
> http://stackoverflow.com/questions/978061/http-get-with-request-body
> http://dret.typepad.com/dretblog/2007/10/http-get-with-m.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira