You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-user@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2016/09/06 20:54:36 UTC

Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

The API module method
org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is @since
2.7 and is only called from the Core module. I propose we move it to Core.

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

Posted by Matt Sicker <bo...@gmail.com>.
If you move it to Loader, you can just use StatusLogger. LowLevelLogUtil is
there for the classes that have to load before StatusLogger can properly
load.

On 6 September 2016 at 21:08, Gary Gregory <ga...@gmail.com> wrote:

> Hm, that methods depends on the package private class LowLevelLogUtil. So
> moving the method to Core would mean making LowLevelLogUtil public. I'm not
> sure that's a good tradeoff...
>
> Gary
>
> On Tue, Sep 6, 2016 at 7:44 PM, Remko Popma <re...@gmail.com> wrote:
>
> > Ah! I didn't look at the code. If there's no risk of breaking user code I
> > have no objection.
> >
> > Apologies.
> >
> > Sent from my iPhone
> >
> > > On 2016/09/07, at 8:11, Gary Gregory <ga...@gmail.com> wrote:
> > >
> > > How could moving an API marked @since 2.7 break user code?
> > >
> > > Gary
> > >
> > >> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma <re...@gmail.com>
> > wrote:
> > >>
> > >> Is there a problem that needs solving here?
> > >> I know we consider the API module's util package private, but I really
> > >> don't like making changes that could break user code for no good
> > reason...
> > >>
> > >> Sent from my iPhone
> > >>
> > >>> On 2016/09/07, at 6:36, Matt Sicker <bo...@gmail.com> wrote:
> > >>>
> > >>> Might as well. If we need it in api, we can move it back later.
> > >>>
> > >>>> On 6 September 2016 at 15:54, Gary Gregory <ga...@gmail.com>
> > >> wrote:
> > >>>>
> > >>>> The API module method
> > >>>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String)
> is
> > >>>> @since
> > >>>> 2.7 and is only called from the Core module. I propose we move it to
> > >> Core.
> > >>>>
> > >>>> Gary
> > >>>>
> > >>>> --
> > >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > >>>> Java Persistence with Hibernate, Second Edition
> > >>>> <http://www.manning.com/bauer3/>
> > >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > >>>> Spring Batch in Action <http://www.manning.com/templier/>
> > >>>> Blog: http://garygregory.wordpress.com
> > >>>> Home: http://garygregory.com/
> > >>>> Tweet! http://twitter.com/GaryGregory
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Matt Sicker <bo...@gmail.com>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> > >> For additional commands, e-mail: log4j-user-help@logging.apache.org
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> > For additional commands, e-mail: log4j-user-help@logging.apache.org
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

Posted by Gary Gregory <ga...@gmail.com>.
Hm, that methods depends on the package private class LowLevelLogUtil. So
moving the method to Core would mean making LowLevelLogUtil public. I'm not
sure that's a good tradeoff...

Gary

On Tue, Sep 6, 2016 at 7:44 PM, Remko Popma <re...@gmail.com> wrote:

> Ah! I didn't look at the code. If there's no risk of breaking user code I
> have no objection.
>
> Apologies.
>
> Sent from my iPhone
>
> > On 2016/09/07, at 8:11, Gary Gregory <ga...@gmail.com> wrote:
> >
> > How could moving an API marked @since 2.7 break user code?
> >
> > Gary
> >
> >> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma <re...@gmail.com>
> wrote:
> >>
> >> Is there a problem that needs solving here?
> >> I know we consider the API module's util package private, but I really
> >> don't like making changes that could break user code for no good
> reason...
> >>
> >> Sent from my iPhone
> >>
> >>> On 2016/09/07, at 6:36, Matt Sicker <bo...@gmail.com> wrote:
> >>>
> >>> Might as well. If we need it in api, we can move it back later.
> >>>
> >>>> On 6 September 2016 at 15:54, Gary Gregory <ga...@gmail.com>
> >> wrote:
> >>>>
> >>>> The API module method
> >>>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
> >>>> @since
> >>>> 2.7 and is only called from the Core module. I propose we move it to
> >> Core.
> >>>>
> >>>> Gary
> >>>>
> >>>> --
> >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >>>> Java Persistence with Hibernate, Second Edition
> >>>> <http://www.manning.com/bauer3/>
> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>>> Spring Batch in Action <http://www.manning.com/templier/>
> >>>> Blog: http://garygregory.wordpress.com
> >>>> Home: http://garygregory.com/
> >>>> Tweet! http://twitter.com/GaryGregory
> >>>
> >>>
> >>>
> >>> --
> >>> Matt Sicker <bo...@gmail.com>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> >> For additional commands, e-mail: log4j-user-help@logging.apache.org
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-user-help@logging.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

Posted by Remko Popma <re...@gmail.com>.
Ah! I didn't look at the code. If there's no risk of breaking user code I have no objection. 

Apologies. 

Sent from my iPhone

> On 2016/09/07, at 8:11, Gary Gregory <ga...@gmail.com> wrote:
> 
> How could moving an API marked @since 2.7 break user code?
> 
> Gary
> 
>> On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma <re...@gmail.com> wrote:
>> 
>> Is there a problem that needs solving here?
>> I know we consider the API module's util package private, but I really
>> don't like making changes that could break user code for no good reason...
>> 
>> Sent from my iPhone
>> 
>>> On 2016/09/07, at 6:36, Matt Sicker <bo...@gmail.com> wrote:
>>> 
>>> Might as well. If we need it in api, we can move it back later.
>>> 
>>>> On 6 September 2016 at 15:54, Gary Gregory <ga...@gmail.com>
>> wrote:
>>>> 
>>>> The API module method
>>>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
>>>> @since
>>>> 2.7 and is only called from the Core module. I propose we move it to
>> Core.
>>>> 
>>>> Gary
>>>> 
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>> 
>>> 
>>> 
>>> --
>>> Matt Sicker <bo...@gmail.com>
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-user-help@logging.apache.org
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-user-help@logging.apache.org

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

Posted by Gary Gregory <ga...@gmail.com>.
How could moving an API marked @since 2.7 break user code?

Gary

On Tue, Sep 6, 2016 at 6:34 PM, Remko Popma <re...@gmail.com> wrote:

> Is there a problem that needs solving here?
> I know we consider the API module's util package private, but I really
> don't like making changes that could break user code for no good reason...
>
> Sent from my iPhone
>
> > On 2016/09/07, at 6:36, Matt Sicker <bo...@gmail.com> wrote:
> >
> > Might as well. If we need it in api, we can move it back later.
> >
> >> On 6 September 2016 at 15:54, Gary Gregory <ga...@gmail.com>
> wrote:
> >>
> >> The API module method
> >> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
> >> @since
> >> 2.7 and is only called from the Core module. I propose we move it to
> Core.
> >>
> >> Gary
> >>
> >> --
> >> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> Java Persistence with Hibernate, Second Edition
> >> <http://www.manning.com/bauer3/>
> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >> Spring Batch in Action <http://www.manning.com/templier/>
> >> Blog: http://garygregory.wordpress.com
> >> Home: http://garygregory.com/
> >> Tweet! http://twitter.com/GaryGregory
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-user-help@logging.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

Posted by Remko Popma <re...@gmail.com>.
Is there a problem that needs solving here?
I know we consider the API module's util package private, but I really don't like making changes that could break user code for no good reason...

Sent from my iPhone

> On 2016/09/07, at 6:36, Matt Sicker <bo...@gmail.com> wrote:
> 
> Might as well. If we need it in api, we can move it back later.
> 
>> On 6 September 2016 at 15:54, Gary Gregory <ga...@gmail.com> wrote:
>> 
>> The API module method
>> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
>> @since
>> 2.7 and is only called from the Core module. I propose we move it to Core.
>> 
>> Gary
>> 
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> Matt Sicker <bo...@gmail.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-user-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-user-help@logging.apache.org

Re: Move org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) to Core?

Posted by Matt Sicker <bo...@gmail.com>.
Might as well. If we need it in api, we can move it back later.

On 6 September 2016 at 15:54, Gary Gregory <ga...@gmail.com> wrote:

> The API module method
> org.apache.logging.log4j.util.LoaderUtil.isClassAvailable(String) is
> @since
> 2.7 and is only called from the Core module. I propose we move it to Core.
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <bo...@gmail.com>