[jira] [Commented] (ZOOKEEPER-575) remove System.exit calls to make the server more container friendly

["Andrew Finnell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096677#comment-13096677 ] 

Andrew Finnell commented on ZOOKEEPER-575:
------------------------------------------

The Stack trace formatting did not translate well into JIRA. 

Things to note: When coming from Learner, there are two entry points, thus two possible exit points. Both end in QuorumPeer.run though. 

> remove System.exit calls to make the server more container friendly
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-575
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-575
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Andrew Finnell
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-575.patch
>
>
> There are a handful of places left in the code that still use System.exit, we should remove these to make the server
> more container friendly.
> There are some legitimate places for the exits - in *Main.java for example should be fine - these are the command
> line main routines. Containers should be embedding code that runs just below this layer (or we should refactor
> so that it would).
> The tricky bit is ensuring the server shuts down in case of an unrecoverable error occurring, afaik these are the
> locations where we still have sys exit calls.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira