You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/11/22 15:41:05 UTC
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2070: [SCB-2121] allow customize query codec, not only hardcode as multi/cs…
codecov-io commented on pull request #2070:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2070#issuecomment-731766563
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=h1) Report
> Merging [#2070](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=desc) (3e7079b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/e953e2db4eeba1122a11ed87f0a03c255c618ddf?el=desc) (e953e2d) will **increase** coverage by `0.03%`.
> The diff coverage is `87.70%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2070 +/- ##
============================================
+ Coverage 81.50% 81.54% +0.03%
Complexity 1296 1296
============================================
Files 1417 1427 +10
Lines 39062 39098 +36
Branches 3338 3335 -3
============================================
+ Hits 31838 31882 +44
+ Misses 5781 5767 -14
- Partials 1443 1449 +6
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cecomb/common/rest/codec/query/QueryCodecJson.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjSnNvbi5qYXZh) | `52.63% <52.63%> (ø)` | `0.00 <0.00> (?)` | |
| [...rvicecomb/common/rest/codec/query/QueryCodecs.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjcy5qYXZh) | `72.22% <72.22%> (ø)` | `0.00 <0.00> (?)` | |
| [...mmon/rest/codec/query/QueryCodecWithDelimiter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjV2l0aERlbGltaXRlci5qYXZh) | `95.23% <95.23%> (ø)` | `0.00 <0.00> (?)` | |
| [...ommon/rest/codec/param/AbstractParamProcessor.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9wYXJhbS9BYnN0cmFjdFBhcmFtUHJvY2Vzc29yLmphdmE=) | `100.00% <100.00%> (+7.69%)` | `0.00 <0.00> (ø)` | |
| [...common/rest/codec/param/QueryProcessorCreator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9wYXJhbS9RdWVyeVByb2Nlc3NvckNyZWF0b3IuamF2YQ==) | `93.75% <100.00%> (-1.13%)` | `0.00 <0.00> (ø)` | |
| [...mb/common/rest/codec/query/AbstractQueryCodec.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9BYnN0cmFjdFF1ZXJ5Q29kZWMuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ervicecomb/common/rest/codec/query/QueryCodec.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...icecomb/common/rest/codec/query/QueryCodecCsv.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjQ3N2LmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ecomb/common/rest/codec/query/QueryCodecMulti.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjTXVsdGkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ecomb/common/rest/codec/query/QueryCodecPipes.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9xdWVyeS9RdWVyeUNvZGVjUGlwZXMuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [25 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=footer). Last update [e953e2d...3e7079b](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org