You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/09/24 11:23:54 UTC

Review Request 38712: Sqoop2: CommonRepositoryHandler#inUseLink only check if link is used in the from side of a job

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38712/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2588
    https://issues.apache.org/jira/browse/SQOOP-2588


Repository: sqoop-sqoop2


Description
-------

CommonRepositoryHandler#inUseLink should check if link is used in the from side of a job or to side of a job.


Diffs
-----

  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 9c45fe7 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java aa872ab 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java cd4c76c 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 40bac8b 
  repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java 72fa981 
  repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java 498f18f 

Diff: https://reviews.apache.org/r/38712/diff/


Testing
-------


Thanks,

Dian Fu


Re: Review Request 38712: Sqoop2: CommonRepositoryHandler#inUseLink only check if link is used in the from side of a job

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38712/#review100458
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Sept. 24, 2015, 9:23 a.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38712/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 9:23 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2588
>     https://issues.apache.org/jira/browse/SQOOP-2588
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> CommonRepositoryHandler#inUseLink should check if link is used in the from side of a job or to side of a job.
> 
> 
> Diffs
> -----
> 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 9c45fe7 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java aa872ab 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java cd4c76c 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 40bac8b 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestLinkHandling.java 72fa981 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java 498f18f 
> 
> Diff: https://reviews.apache.org/r/38712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>