You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/09/21 12:15:00 UTC

[jira] [Commented] (AMQ-6820) NIO transport should properly handle ClosedChannelException

    [ https://issues.apache.org/jira/browse/AMQ-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174643#comment-16174643 ] 

ASF subversion and git services commented on AMQ-6820:
------------------------------------------------------

Commit 6e33507bf2fc2acea9f61e230cf8e2a9cbccc3ce in activemq's branch refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=6e33507 ]

AMQ-6820 - Properly handle ClosedChannelException

When a ClosedChannelException occurs inside SelectorSelection properly
call the transport listener onError() method to handle cleanup and
logging.


> NIO transport should properly handle ClosedChannelException
> -----------------------------------------------------------
>
>                 Key: AMQ-6820
>                 URL: https://issues.apache.org/jira/browse/AMQ-6820
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 5.15.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>             Fix For: 5.15.1, 5.16.0
>
>
> The NIO transport does not properly handle a ClosedChannelException when it happens inside the SelectorSelection class.  Instead of properly disposing of the transport it calls System.out.println() for the exception and keeps the transport alive.  This caused a NPE later when the enable() method was called because the SelectionKey was null.  The fix is to call onError() when the ClosedChannelException occurs so things get cleaned up and logged properly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)