You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/29 05:34:19 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
AngersZhuuuu opened a new pull request #30958:
URL: https://github.com/apache/spark/pull/30958
### What changes were proposed in this pull request?
For same SQL
```
SELECT TRANSFORM(a, b, c, null)
ROW FORMAT DELIMITED
USING 'cat'
ROW FORMAT DELIMITED
FIELDS TERMINATED BY '&'
FROM (select 1 as a, 2 as b, 3 as c) t
```
In hive:
In Spark
We should keep same. Change default ROW FORMAT FIELD DELIMIT to `\u0001`
### Why are the changes needed?
Keep same behavior with hive
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752006983
**[Test build #133489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133489/testReport)** for PR 30958 at commit [`75bfd87`](https://github.com/apache/spark/commit/75bfd8781ba0052000d1bf4ad328f95cefc7cee5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751986675
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38058/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752028091
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38078/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752016245
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38073/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value should be '\u0001'?
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751993055
Maybe "Script Transform default FIELD DELIMIT should be \u0001 for no serde".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751987692
**[Test build #133479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133479/testReport)** for PR 30958 at commit [`3c6a4ee`](https://github.com/apache/spark/commit/3c6a4eef2f7258de0e69c11d67f538925cd9af5b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751958635
**[Test build #133470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133470/testReport)** for PR 30958 at commit [`1812826`](https://github.com/apache/spark/commit/1812826f67cc41ed8efb961e793c74a975e27d5d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752004374
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133470/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #30958:
URL: https://github.com/apache/spark/pull/30958#discussion_r549624404
##########
File path: docs/sql-migration-guide.md
##########
@@ -30,6 +30,8 @@ license: |
- In Spark 3.2, `ALTER TABLE .. RENAME TO PARTITION` throws `PartitionAlreadyExistsException` instead of `AnalysisException` for tables from Hive external when the target partition already exists.
+ - In Spark 3.2, script transform default `FIELD DELIMIT` is `\u0001` for no serde mode. In Spark 3.1 or earlier, the default `FIELD DELIMIT` is `\t`.
Review comment:
> Do we need backquote? Maybe `` `FIELD DELIMIT` `` -> `FIELD DELIMIT`?
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751953177
FYI @maropu @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30958:
URL: https://github.com/apache/spark/pull/30958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752002753
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38068/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752095541
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752066616
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133484/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752033319
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38073/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752084512
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133489/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752018687
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38068/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752019941
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38078/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751992712
Spark SQL no serde row format field delimit default value is '\u0001' -> Spark SQL no serde row format field delimit default value should be '\u0001'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752074315
**[Test build #133489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133489/testReport)** for PR 30958 at commit [`75bfd87`](https://github.com/apache/spark/commit/75bfd8781ba0052000d1bf4ad328f95cefc7cee5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30958:
URL: https://github.com/apache/spark/pull/30958#discussion_r549623159
##########
File path: docs/sql-migration-guide.md
##########
@@ -30,6 +30,8 @@ license: |
- In Spark 3.2, `ALTER TABLE .. RENAME TO PARTITION` throws `PartitionAlreadyExistsException` instead of `AnalysisException` for tables from Hive external when the target partition already exists.
+ - In Spark 3.2, script transform default `FIELD DELIMIT` is `\u0001` for no serde mode. In Spark 3.1 or earlier, the default `FIELD DELIMIT` is `\t`.
Review comment:
Do we need backquote? Maybe ``` `FIELD DELIMIT` ``` -> `FIELD DELIMIT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751995606
> This also changes current behavior. Shall we update the SQL migration guide too?
How about current updated migration guide doc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752038798
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133479/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752038402
**[Test build #133479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133479/testReport)** for PR 30958 at commit [`3c6a4ee`](https://github.com/apache/spark/commit/3c6a4eef2f7258de0e69c11d67f538925cd9af5b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751974605
> Not related to the change. But I notice that some contributors usually use screenshots in the description. I personally don't recommend this approach. The images cannot be indexed and searched. So I suggest that for problem and fix description, some text are more helpful.
Yea， thanks for your suggestion, I will update pr desc. And will pay attention to this problem.
Maybe we should sen an email to mention this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752006983
**[Test build #133489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133489/testReport)** for PR 30958 at commit [`75bfd87`](https://github.com/apache/spark/commit/75bfd8781ba0052000d1bf4ad328f95cefc7cee5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752018687
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38068/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751986675
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38058/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752004374
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133470/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752035475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752004108
**[Test build #133484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133484/testReport)** for PR 30958 at commit [`4691cb3`](https://github.com/apache/spark/commit/4691cb328c56b728586fb3c1893ff77983b90744).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752035478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752066616
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133484/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752004108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30958:
URL: https://github.com/apache/spark/pull/30958#discussion_r549600913
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala
##########
@@ -440,6 +441,31 @@ abstract class BaseScriptTransformationSuite extends SparkPlanTest with SQLTestU
}
}
}
+
+ test("SPARK-33930: Script Transform default FIELD DELIMIT should be \u0001 (no serde)") {
+ withTempView("v") {
+ val df = Seq(
+ (1, 2, 3),
+ (2, 3, 4),
+ (3, 4, 5)
+ ).toDF("a", "b", "c") // Note column d's data type is Decimal(38, 18)
Review comment:
where is column d?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752059690
**[Test build #133484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133484/testReport)** for PR 30958 at commit [`4691cb3`](https://github.com/apache/spark/commit/4691cb328c56b728586fb3c1893ff77983b90744).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752084512
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133489/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #30958:
URL: https://github.com/apache/spark/pull/30958#discussion_r549601552
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala
##########
@@ -440,6 +441,31 @@ abstract class BaseScriptTransformationSuite extends SparkPlanTest with SQLTestU
}
}
}
+
+ test("SPARK-33930: Script Transform default FIELD DELIMIT should be \u0001 (no serde)") {
+ withTempView("v") {
+ val df = Seq(
+ (1, 2, 3),
+ (2, 3, 4),
+ (3, 4, 5)
+ ).toDF("a", "b", "c") // Note column d's data type is Decimal(38, 18)
Review comment:
> where is column d?
Remove this unrelated comment. Copy code from other UT..forgot remove this comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751974605
> Not related to the change. But I notice that some contributors usually use screenshots in the description. I personally don't recommend this approach. The images cannot be indexed and searched. So I suggest that for problem and fix description, some text are more helpful.
Yea， thanks for your suggestion, I will update pr desc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Script Transform default FIELD DELIMIT should be \u0001 for no serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-752011989
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38068/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751987692
**[Test build #133479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133479/testReport)** for PR 30958 at commit [`3c6a4ee`](https://github.com/apache/spark/commit/3c6a4eef2f7258de0e69c11d67f538925cd9af5b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value should be '\u0001'?
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751993055
Maybe "Script Transform default FIELD DELIMIT should be \u0001 for no serde"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30958: [SPARK-33930][SQL] Spark SQL no serde row format field delimit default value is '\u0001'
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30958:
URL: https://github.com/apache/spark/pull/30958#issuecomment-751958635
**[Test build #133470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133470/testReport)** for PR 30958 at commit [`1812826`](https://github.com/apache/spark/commit/1812826f67cc41ed8efb961e793c74a975e27d5d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org