You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by so...@apache.org on 2015/09/25 00:19:34 UTC

falcon git commit: FALCON-1470 HiveDRStatusStoreTest should fail when using fakeGroup to create StatusStore. Contributed by Balu Vellanki.

Repository: falcon
Updated Branches:
  refs/heads/master 9a2acebf7 -> 8b6f7c526


FALCON-1470 HiveDRStatusStoreTest should fail when using fakeGroup to create StatusStore. Contributed by Balu Vellanki.


Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/8b6f7c52
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/8b6f7c52
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/8b6f7c52

Branch: refs/heads/master
Commit: 8b6f7c5267ef27dd2dc6358d54358a2b645e6b9e
Parents: 9a2aceb
Author: Sowmya Ramesh <sr...@hortonworks.com>
Authored: Thu Sep 24 15:19:27 2015 -0700
Committer: Sowmya Ramesh <sr...@hortonworks.com>
Committed: Thu Sep 24 15:19:27 2015 -0700

----------------------------------------------------------------------
 CHANGES.txt                                          |  2 ++
 .../apache/falcon/hive/HiveDRStatusStoreTest.java    | 15 ++++++---------
 2 files changed, 8 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/falcon/blob/8b6f7c52/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 4c0462a..96eae36 100755
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -39,6 +39,8 @@ Trunk (Unreleased)
     FALCON-1403 Revisit IT cleanup and teardown(Narayan Periwal via Pallavi Rao)
 
   BUG FIXES
+    FALCON-1470 HiveDRStatusStoreTest should fail when using fakeGroup to create StatusStore(Balu Vellanki via Sowmya Ramesh)
+
     FALCON-1462 Modify use of "testuser" in UTs and ITs(Narayan Periwal via Sowmya Ramesh)
 
     FALCON-1484 Find Bundles fails in case of hadoop namenode moving to HA(Sandeep Samudrala via Pallavi Rao)

http://git-wip-us.apache.org/repos/asf/falcon/blob/8b6f7c52/addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java
----------------------------------------------------------------------
diff --git a/addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java b/addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java
index c89c661..5bc39df 100644
--- a/addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java
+++ b/addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java
@@ -54,15 +54,6 @@ public class HiveDRStatusStoreTest {
             fileSystem.delete(storePath, true);
         }
         FileSystem.mkdirs(fileSystem, storePath, DRStatusStore.DEFAULT_STORE_PERMISSION);
-        try {
-            new HiveDRStatusStore(fileSystem);
-            Assert.fail();
-        } catch (IOException ie) {
-            // Exception expected.
-            Assert.assertEquals(ie.getMessage(), "Base dir jail://hiveReplTest:00" + storePath.toUri()
-                    + " does not have correct ownership/permissions."
-                    + " Please set group to " + DRStatusStore.getStoreGroup() + " and permissions to rwxrwx---");
-        }
         drStatusStore = new HiveDRStatusStore(fileSystem, fileSystem.getFileStatus(storePath).getGroup());
     }
 
@@ -87,6 +78,12 @@ public class HiveDRStatusStoreTest {
         drStatusStore.updateReplicationStatus("jobname", replicationStatusList);
     }
 
+    @Test(expectedExceptions = IOException.class,
+            expectedExceptionsMessageRegExp = ".*does not have correct ownership/permissions.*")
+    public void testDrStatusStoreWithFakeUser() throws IOException {
+        new HiveDRStatusStore(fileSystem, "fakeGroup");
+    }
+
     public  void updateReplicationStatusNewTablesTest() throws Exception {
         ReplicationStatus dbStatus = new ReplicationStatus("source", "target", "jobname2",
                 "default2", null, ReplicationStatus.Status.SUCCESS, 20L);