[GitHub] [storm] agresch commented on a change in pull request #3226: [STORM-3583] Handle exceptions when AsyncLocalizer tries to get local resources

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3226: [STORM-3583] Handle exceptions when AsyncLocalizer tries to get local resources
URL: https://github.com/apache/storm/pull/3226#discussion_r391672288
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
 ##########
 @@ -456,7 +457,21 @@ public void releaseSlotFor(LocalAssignment assignment, int port) throws IOExcept
             topoConfBlob.removeReference(pna);
         }
 
-        for (LocalResource lr : getLocalResources(pna)) {
+        List<LocalResource> localResources = null;
+        try {
+            // Precondition1: Base blob stormconf.ser and stormcode.ser have been localized
+            // Precondition2: Both these two blob files are fully downloaded and proper permission been set
+            localResources = getLocalResources(pna);
+        } catch (FileNotFoundException fnfException) {
+            LOG.warn("Local base blobs have not been downloaded yet. "
 
 Review comment:
   can we add the pna to this message and the IOException error?  What is the side effect of not releasing this if there's a race condition?  Could the localizer then be updating this file continually?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services