You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Funk (JIRA)" <ji...@apache.org> on 2010/12/10 14:30:03 UTC
[jira] Created: (WICKET-3251) How to set custom HTTP response
header in Wicket's Ajax responses?
How to set custom HTTP response header in Wicket's Ajax responses?
------------------------------------------------------------------
Key: WICKET-3251
URL: https://issues.apache.org/jira/browse/WICKET-3251
Project: Wicket
Issue Type: Bug
Reporter: Martin Funk
http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3251) How to set custom HTTP response
header in Wicket's Ajax responses?
Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970173#action_12970173 ]
Martin Funk commented on WICKET-3251:
-------------------------------------
The custom filter solution is prbobably nicer, if the needed values are within reach of the filter.
Basically overriding getWebResponse() only has an effect for non-Ajax calls.
This is because the AjaxRequestTarget is calling getResponse(), which is final.
So the suggestion of the patch is to let it call getWebResponse().
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3251) How to set custom HTTP
response header in Wicket's Ajax responses?
Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970173#action_12970173 ]
Martin Funk edited comment on WICKET-3251 at 12/10/10 9:05 AM:
---------------------------------------------------------------
The custom filter solution is probably nicer, if the needed values are within reach of the filter.
Basically overriding getWebResponse() only has an effect for non-Ajax calls.
This is because the AjaxRequestTarget is calling getResponse(), which is final.
So the suggestion of the patch is to let it call getWebResponse().
was (Author: funkattack):
The custom filter solution is prbobably nicer, if the needed values are within reach of the filter.
Basically overriding getWebResponse() only has an effect for non-Ajax calls.
This is because the AjaxRequestTarget is calling getResponse(), which is final.
So the suggestion of the patch is to let it call getWebResponse().
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3251) How to set custom HTTP response
header in Wicket's Ajax responses?
Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Funk updated WICKET-3251:
--------------------------------
Attachment: Wicket-3251.diff
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3251) How to set custom HTTP
response header in Wicket's Ajax responses?
Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970173#action_12970173 ]
Martin Funk edited comment on WICKET-3251 at 12/10/10 9:05 AM:
---------------------------------------------------------------
The custom filter solution is probably nicer, if the needed values are within reach of the filter.
Basically overriding getWebResponse() only has an effect for non-Ajax calls.
This is because the AjaxRequestTarget is calling getResponse(), which is final.
So the suggestion of the patch is to let it call getWebResponse() instead.
was (Author: funkattack):
The custom filter solution is probably nicer, if the needed values are within reach of the filter.
Basically overriding getWebResponse() only has an effect for non-Ajax calls.
This is because the AjaxRequestTarget is calling getResponse(), which is final.
So the suggestion of the patch is to let it call getWebResponse().
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3251) How to set custom HTTP response
header in Wicket's Ajax responses?
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-3251:
-------------------------------------
Fix Version/s: (was: 1.4.15)
(was: 1.5-M4)
Removing fix versions on things that were marked as fixVersion = (1.4.14 || 1.5-M4), but also weren't fixed (marked "not a problem", "won't fix", etc) so that they don't show up in release notes when in reality they weren't part of the release.
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3251) How to set custom HTTP response
header in Wicket's Ajax responses?
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970170#action_12970170 ]
Martin Grigorov commented on WICKET-3251:
-----------------------------------------
The attached diff doesn't make sense. Just different way to cast.
I prefer the solution with the custom filter, but using WebRequestCycle.get().getWebResponse().setHeader() should be ok.
Can you attach a quickstart that shows the problem ? I think custom WebRequestCycle should work for Ajax as well. I see no difference.
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3251) How to set custom HTTP response
header in Wicket's Ajax responses?
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3251.
-------------------------------------
Resolution: Cannot Reproduce
Fix Version/s: 1.5-M4
1.4.15
I just tested with custom RequestCycle and the header is set for both Ajax and normal requests.
> How to set custom HTTP response header in Wicket's Ajax responses?
> ------------------------------------------------------------------
>
> Key: WICKET-3251
> URL: https://issues.apache.org/jira/browse/WICKET-3251
> Project: Wicket
> Issue Type: Bug
> Reporter: Martin Funk
> Fix For: 1.4.15, 1.5-M4
>
> Attachments: Wicket-3251.diff
>
>
> http://stackoverflow.com/questions/4397211/how-to-set-custom-http-response-header-in-wickets-ajax-responses/4399434#4399434
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.