You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/04 08:37:35 UTC
[GitHub] [camel-spring-boot] amdmdi opened a new pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
amdmdi opened a new pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103
Created additional-spring-configuration-metadata.json to add description
to properties inherited from parent configuration classes.
This is because spring-boot-configuration-processor detects inherited
properties by their public getters/setters but can not find the corresponding
javadoc used for generated adoc in the parent classes.
This is the second possible solution for issue CAMEL-14565. Another is copy fields from
parent classes to include the javadoc (and default values)
I created a second pull request for **camel-zookeeper-starter** using the other solution.
Please advise on which solution is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] amdmdi commented on pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
Posted by GitBox <gi...@apache.org>.
amdmdi commented on pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103#issuecomment-653739473
See also PR #104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] amdmdi closed pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
Posted by GitBox <gi...@apache.org>.
amdmdi closed pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] amdmdi commented on pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
Posted by GitBox <gi...@apache.org>.
amdmdi commented on pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103#issuecomment-653741074
PS: I first created this file by using jq on the one spring processor generates :
cat target/classes/META-INF/spring-configuration-metadata.json | jq ' .properties | map(select(has("description") | not)) | .[] += {description: "TODO", defaultValue: "TODO"} | {properties: .}'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103#issuecomment-653742352
Lets go with the other javadoc style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] amdmdi edited a comment on pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
Posted by GitBox <gi...@apache.org>.
amdmdi edited a comment on pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103#issuecomment-653741074
PS: I first created this file by using jq on the one spring processor generates :
`cat target/classes/META-INF/spring-configuration-metadata.json | jq ' .properties | map(select(has("description") | not)) | .[] += {description: "TODO", defaultValue: "TODO"} | {properties: .}'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] amdmdi commented on pull request #103: [CAMEL-14565] Add additional metadata json file to include description docs for spring properties
Posted by GitBox <gi...@apache.org>.
amdmdi commented on pull request #103:
URL: https://github.com/apache/camel-spring-boot/pull/103#issuecomment-653763868
OK, I created PR #105 with the javadoc solution for **camel-consul-starter** too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org