[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1315: MINIFICPP-1810 Provide logs to be read from docker logs

[GitBox <gi...@apache.org>]

szaszm commented on code in PR #1315:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1315#discussion_r855525744


##########
docker/Dockerfile:
##########
@@ -174,9 +174,12 @@ RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G ${USER} -g "" ${USER}
 
 # Copy built minifi distribution from builder
 COPY --from=build --chown=${USER}:${USER} ${MINIFI_VERSIONED_HOME} ${MINIFI_HOME}
+RUN mkdir ${MINIFI_HOME}/scripts
+COPY --from=build --chown=${USER}:${USER} ${MINIFI_BASE_DIR}/docker/scripts/start.sh ${MINIFI_HOME}/scripts
+RUN chmod +x ${MINIFI_HOME}/scripts/start.sh
 
 USER ${USER}
 WORKDIR ${MINIFI_HOME}
 
 # Start MiNiFi CPP in the foreground
-CMD ["./bin/minifi.sh", "run"]
+CMD ["./scripts/start.sh"]

Review Comment:
   Instead of this script, we should configure the minifi logger to output logs to stdout, through `minifi-log.properties`. Can we do that in the context of the docker image?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org