You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/24 13:46:35 UTC
[GitHub] [avro] sekikn opened a new pull request #1143: AVRO-3084: Fix JavaScript interop test to read files generated by other languages on CI
sekikn opened a new pull request #1143:
URL: https://github.com/apache/avro/pull/1143
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3084
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
I ran the "Test JavaScript" workflow in my GitHub repository and confirmed that py.avro and py_deflate.avro were successfully generated and checked.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g closed pull request #1143: AVRO-3084: Fix JavaScript interop test to read files generated by other languages on CI
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1143:
URL: https://github.com/apache/avro/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1143: AVRO-3084: Fix JavaScript interop test to read files generated by other languages on CI
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1143:
URL: https://github.com/apache/avro/pull/1143#issuecomment-1020120924
```
avro/lang/js on branch-1.11 [$?] is 📦 v1.11.1-SNAPSHOT via ⬢ v12.18.3 on ☁️ eu-central-1
❯ ./build.sh interop-data-test
> avro-js@1.11.1-SNAPSHOT interop-data-test /home/martin/git/apache/avro/lang/js
> mocha test/interop_data_test.js
interop
Skipped: java.avro
Skipped: java_bzip2.avro
Skipped: java_deflate.avro
Skipped: java_snappy.avro
Skipped: java_xz.avro
Skipped: java_zstandard.avro
Reading js.avro
Reading js_deflate.avro
Reading perl.avro
Skipped: perl_bzip2.avro
Reading perl_deflate.avro
Skipped: perl_zstandard.avro
Reading py.avro
Skipped: py_bzip2.avro
Reading py_deflate.avro
Reading rust.avro
Skipped: rust_bzip2.avro
Reading rust_deflate.avro
Skipped: rust_snappy.avro
Skipped: rust_xz.avro
Skipped: rust_zstandard.avro
Skipped: rust_zstd.avro
```
```
ll ../../build/interop/data/
.rw-rw-r-- martin martin 36 KB Mon Jan 24 15:44:52 2022 java.avro
.rw-rw-r-- martin martin 28 KB Mon Jan 24 15:44:52 2022 java_bzip2.avro
.rw-rw-r-- martin martin 30 KB Mon Jan 24 15:44:52 2022 java_deflate.avro
.rw-rw-r-- martin martin 35 KB Mon Jan 24 15:44:52 2022 java_snappy.avro
.rw-rw-r-- martin martin 28 KB Mon Jan 24 15:44:52 2022 java_xz.avro
.rw-rw-r-- martin martin 30 KB Mon Jan 24 15:44:52 2022 java_zstandard.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 js.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 js_deflate.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl_bzip2.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl_deflate.avro
.rw-rw-r-- martin martin 1.2 KB Tue Jan 18 00:25:03 2022 perl_zstandard.avro
.rw-rw-r-- martin martin 1.4 KB Mon Jan 24 15:44:52 2022 py.avro
.rw-rw-r-- martin martin 1.4 KB Mon Jan 24 15:44:52 2022 py_bzip2.avro
.rw-rw-r-- martin martin 1.3 KB Mon Jan 24 15:44:52 2022 py_deflate.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_bzip2.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_deflate.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_snappy.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_xz.avro
.rw-rw-r-- martin martin 1.1 KB Wed Jan 19 12:07:00 2022 rust_zstandard.avro
.rw-rw-r-- martin martin 1.1 KB Mon Jan 24 15:44:52 2022 rust_zstd.avro
```
It seems JS supports only the `null` and `deflate` codecs. Python supports the same two + `bzip2`, so it should be OK!
If more codecs are added later to JS we will need to use another module for interop that supports all of them, e.g. Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1143: AVRO-3084: Fix JavaScript interop test to read files generated by other languages on CI
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1143:
URL: https://github.com/apache/avro/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1143: AVRO-3084: Fix JavaScript interop test to read files generated by other languages on CI
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1143:
URL: https://github.com/apache/avro/pull/1143#issuecomment-1020118214
Closed/reopened this PR to re-trigger the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org