You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2016/01/22 14:04:39 UTC
Review Request 42651: [FALCON-1766] Add CLI metrics check for hiveDR
and feed replication
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1766
https://issues.apache.org/jira/browse/FALCON-1766
Repository: falcon-git
Description
-------
Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
Diff: https://reviews.apache.org/r/42651/diff/
Testing
-------
Tested
Thanks,
Paul Isaychuk
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
hiveDR and feed replication
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/#review116378
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java (line 147)
<https://reviews.apache.org/r/42651/#comment177418>
I've checked the same with checkstyle, it doesn't complain
- Paul Isaychuk
On Jan. 22, 2016, 1:04 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42651/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 1:04 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1766
> https://issues.apache.org/jira/browse/FALCON-1766
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
>
> Diff: https://reviews.apache.org/r/42651/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
hiveDR and feed replication
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/#review116354
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java (line 147)
<https://reviews.apache.org/r/42651/#comment177399>
Indentation. This will fail in checkStyle
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java (line 62)
<https://reviews.apache.org/r/42651/#comment177401>
null check on output is missing.
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java (line 63)
<https://reviews.apache.org/r/42651/#comment177402>
Java doc should have parameters definition.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java (line 185)
<https://reviews.apache.org/r/42651/#comment177400>
This check can be added to all the test cases in thsi class.
- PRAGYA MITTAL
On Jan. 22, 2016, 1:04 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42651/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 1:04 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1766
> https://issues.apache.org/jira/browse/FALCON-1766
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
>
> Diff: https://reviews.apache.org/r/42651/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
HiveDR, HDFS and feed replication
Posted by Murali Ramasami <mu...@gmail.com>.
> On Feb. 1, 2016, 3:21 p.m., Murali Ramasami wrote:
> > Ship It!
+1 Looks good to me
- Murali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/#review117217
-----------------------------------------------------------
On Feb. 1, 2016, 1:33 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42651/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 1:33 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1766
> https://issues.apache.org/jira/browse/FALCON-1766
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HdfsRecipeTest.java 05b9cf4
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-template.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-workflow.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication.properties PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml 46546ce
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa820d0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 6c715f3
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
>
> Diff: https://reviews.apache.org/r/42651/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
HiveDR, HDFS and feed replication
Posted by Murali Ramasami <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/#review117217
-----------------------------------------------------------
Ship it!
Ship It!
- Murali Ramasami
On Feb. 1, 2016, 1:33 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42651/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 1:33 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1766
> https://issues.apache.org/jira/browse/FALCON-1766
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HdfsRecipeTest.java 05b9cf4
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-template.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-workflow.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication.properties PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml 46546ce
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa820d0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 6c715f3
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
>
> Diff: https://reviews.apache.org/r/42651/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
HiveDR, HDFS and feed replication
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/#review117400
-----------------------------------------------------------
Ship it!
Ship It!
- Peeyush Bishnoi
On Feb. 1, 2016, 1:33 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42651/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 1:33 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1766
> https://issues.apache.org/jira/browse/FALCON-1766
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HdfsRecipeTest.java 05b9cf4
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-template.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-workflow.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication.properties PRE-CREATION
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml 46546ce
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa820d0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 6c715f3
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
>
> Diff: https://reviews.apache.org/r/42651/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
HiveDR, HDFS and feed replication
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 1:33 p.m.)
Review request for Falcon.
Summary (updated)
-----------------
[FALCON-1766] Add CLI metrics check for HiveDR, HDFS and feed replication
Bugs: FALCON-1766
https://issues.apache.org/jira/browse/FALCON-1766
Repository: falcon-git
Description
-------
Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HdfsRecipeTest.java 05b9cf4
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-template.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication-workflow.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/HdfsRecipe/hdfs-replication.properties PRE-CREATION
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml 46546ce
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa820d0
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 6c715f3
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
Diff: https://reviews.apache.org/r/42651/diff/
Testing
-------
Tested
Thanks,
Paul Isaychuk
Re: Review Request 42651: [FALCON-1766] Add CLI metrics check for
hiveDR and feed replication
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42651/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 6:57 p.m.)
Review request for Falcon.
Changes
-------
addressed review-comments
Bugs: FALCON-1766
https://issues.apache.org/jira/browse/FALCON-1766
Repository: falcon-git
Description
-------
Add code to check CLI metrics for both HiveDR recipe based process as well as for feed replication.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java 2e6fca9
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e406cae
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 9d3b802
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 6728edf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HdfsRecipeTest.java 05b9cf4
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 7660e04
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml 72d40a3
Diff: https://reviews.apache.org/r/42651/diff/
Testing
-------
Tested
Thanks,
Paul Isaychuk