You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/01/14 04:06:49 UTC
Review Request 65152: ATLAS-2363: Strict DSL parsing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65152/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2363
https://issues.apache.org/jira/browse/ATLAS-2363
Repository: atlas
Description
-------
See JIRA
Diffs
-----
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java ad3d4d225
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 2e132d115
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 8787c52bd
repository/src/test/java/org/apache/atlas/query/DSLParsingTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 36f0bf722
Diff: https://reviews.apache.org/r/65152/diff/1/
Testing
-------
Added new test to check exceptions when bad queries are passed
Existing tests executing successfully
Thanks,
Apoorv Naik
Re: Review Request 65152: ATLAS-2363: Strict DSL parsing
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65152/#review195405
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Jan. 14, 2018, 4:06 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65152/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2018, 4:06 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2363
> https://issues.apache.org/jira/browse/ATLAS-2363
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java ad3d4d225
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 2e132d115
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 8787c52bd
> repository/src/test/java/org/apache/atlas/query/DSLParsingTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 36f0bf722
>
>
> Diff: https://reviews.apache.org/r/65152/diff/1/
>
>
> Testing
> -------
>
> Added new test to check exceptions when bad queries are passed
> Existing tests executing successfully
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 65152: ATLAS-2363: Strict DSL parsing
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65152/#review195399
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 14, 2018, 4:06 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65152/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2018, 4:06 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2363
> https://issues.apache.org/jira/browse/ATLAS-2363
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java ad3d4d225
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 2e132d115
> repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 8787c52bd
> repository/src/test/java/org/apache/atlas/query/DSLParsingTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 36f0bf722
>
>
> Diff: https://reviews.apache.org/r/65152/diff/1/
>
>
> Testing
> -------
>
> Added new test to check exceptions when bad queries are passed
> Existing tests executing successfully
>
>
> Thanks,
>
> Apoorv Naik
>
>