[GitHub] milleruntime commented on a change in pull request #943: Changes to make 2.0 API more backward compatible

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #943: Changes to make 2.0 API more backward compatible
URL: https://github.com/apache/accumulo/pull/943#discussion_r254923602
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java
 ##########
 @@ -50,7 +50,7 @@
  * @deprecated since 2.0.0, replaced by {@link Accumulo#newClient()}
  */
 @Deprecated
-public class ClientConfiguration {
+public class ClientConfiguration extends CompositeConfiguration {
 
 Review comment:
   Why remove the inheritance?  If we are keeping the class for backwards compatibility, removing the super class may still break existing code that uses it. 
   
   Also looks like this class wasn't deprecated in 1.9: https://github.com/apache/accumulo/blob/1.9/core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java#L61

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services