You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/06 06:40:45 UTC
[GitHub] [arrow] kou opened a new pull request, #35459: GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later
kou opened a new pull request, #35459:
URL: https://github.com/apache/arrow/pull/35459
### Rationale for this change
Google Benchmark 1.6.1 added `benchmark::MemoryManager::Stop(Result&)` and deprecated `benchmark::MemoryManager::Stop(Result*)`.
Google Benchmark 1.8.0 dropped deprecated
`benchmark::MemoryManager::Stop(Result*)`.
### What changes are included in this PR?
We can always use `benchmark::MemoryManager::Stop(Result&)` by requiring Google Benchmark 1.6.1 or later.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35459: GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35459:
URL: https://github.com/apache/arrow/pull/35459#issuecomment-1540298373
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/5fba208941c84849801fbeaa4ea58298...afb80cb3985c4b4782a3b4eb35d522e6/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35459: GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35459:
URL: https://github.com/apache/arrow/pull/35459#issuecomment-1537068412
:warning: GitHub issue #35458 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35459: GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35459:
URL: https://github.com/apache/arrow/pull/35459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35459: GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35459:
URL: https://github.com/apache/arrow/pull/35459#issuecomment-1540292374
Benchmark runs are scheduled for baseline = ad43544e5645dd70c9bde11fa9b1988040446db5 and contender = aa8ffbe1a1fe630316c8ce8a0785a0559d0ffb03. aa8ffbe1a1fe630316c8ce8a0785a0559d0ffb03 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dfa994b923ec491092090a98ad126ebc...96090c8d777a4e2b8d24aae25d4f52fc/)
[Failed :arrow_down:3.57% :arrow_up:0.58%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5fba208941c84849801fbeaa4ea58298...afb80cb3985c4b4782a3b4eb35d522e6/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8f0f1996891f4dd3812d84f56baec76a...72485ee38f534b72853b6768f7fd37e4/)
[Failed :arrow_down:5.24% :arrow_up:4.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/92f36c0ae1e5409cb34757d280301eed...ed9ebb62f8f144e596d467f1a22d634c/)
Buildkite builds:
[Finished] [`aa8ffbe1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2833)
[Finished] [`aa8ffbe1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2870)
[Finished] [`aa8ffbe1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2833)
[Finished] [`aa8ffbe1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2860)
[Finished] [`ad43544e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2832)
[Failed] [`ad43544e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2869)
[Finished] [`ad43544e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2832)
[Failed] [`ad43544e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2859)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35459: GH-35458: [C++][Benchmarking] Require Google Benchmark 1.6.1 or later
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35459:
URL: https://github.com/apache/arrow/pull/35459#issuecomment-1537068403
* Closes: #35458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org