[Impala-ASF-CR] PREVIEW: IMPALA-2550 Introduce query-wide execution context.

["Marcel Kornacker (Code Review)" <ge...@cloudera.org>]

Marcel Kornacker has posted comments on this change.

Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3817/3/be/src/service/fragment-mgr.h
File be/src/service/fragment-mgr.h:

Line 28: /// Manages execution of individual plan fragment instances, which are typically run as a
as part of the header preview, please also rewrite the class comments to fully reflect the new abstraction. this is necessary to spell out the intention and also makes it easier to compare the intention with the interface.


http://gerrit.cloudera.org:8080/#/c/3817/3/be/src/service/request-exec-state.h
File be/src/service/request-exec-state.h:

Line 55: class ImpalaServer::RequestExecState {
request is very generic. this is specifically for client requests, so ClientRequestExecState would be better.


-- 
To view, visit http://gerrit.cloudera.org:8080/3817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892091d6401acb2ea91ccb1623af54c6f9635e6c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes