You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2017/12/09 21:15:29 UTC

[2/2] qpid-broker-j git commit: QPID-6933: [System Tests] Move JMSReplyToTest and some tests from JMSDestinationTest into JMS 1.1 system tests

QPID-6933: [System Tests] Move JMSReplyToTest and some tests from JMSDestinationTest into JMS 1.1 system tests


Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/4ac36ca5
Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/4ac36ca5
Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/4ac36ca5

Branch: refs/heads/master
Commit: 4ac36ca5e7169c19f5c39943d563d5253fbfe545
Parents: fc0fd3e
Author: Alex Rudyy <or...@apache.org>
Authored: Sat Dec 9 21:15:12 2017 +0000
Committer: Alex Rudyy <or...@apache.org>
Committed: Sat Dec 9 21:15:12 2017 +0000

----------------------------------------------------------------------
 .../jms_1_1/message/JMSDestinationTest.java     | 192 +++++++++++++++++++
 .../jms_1_1/message/JMSReplyToTest.java         | 128 +++++++++++++
 .../test/client/message/JMSDestinationTest.java | 102 ----------
 .../test/client/message/JMSReplyToTest.java     | 169 ----------------
 test-profiles/cpp.excludes                      |   3 -
 5 files changed, 320 insertions(+), 274 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/4ac36ca5/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSDestinationTest.java
----------------------------------------------------------------------
diff --git a/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSDestinationTest.java b/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSDestinationTest.java
new file mode 100644
index 0000000..2197000
--- /dev/null
+++ b/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSDestinationTest.java
@@ -0,0 +1,192 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.qpid.systests.jms_1_1.message;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+
+import javax.jms.Connection;
+import javax.jms.Destination;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Queue;
+import javax.jms.Session;
+import javax.jms.Topic;
+
+import org.junit.Test;
+
+import org.apache.qpid.systests.JmsTestBase;
+import org.apache.qpid.systests.Utils;
+
+public class JMSDestinationTest extends JmsTestBase
+{
+
+    @Test
+    public void messageSentToQueueComesBackWithTheSameJMSDestination() throws Exception
+    {
+        Queue queue = createQueue(getTestName());
+        Connection connection = getConnection();
+        try
+        {
+            Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+            MessageConsumer consumer = session.createConsumer(queue);
+
+            Utils.sendMessages(session, queue, 1);
+
+            connection.start();
+
+            Message receivedMessage = consumer.receive(getReceiveTimeout());
+            assertNotNull("Message should not be null", receivedMessage);
+
+            Destination receivedDestination = receivedMessage.getJMSDestination();
+
+            assertNotNull("JMSDestination should not be null", receivedDestination);
+            assertTrue("Unexpected destination type", receivedDestination instanceof Queue);
+            assertEquals("Unexpected destination name",
+                         queue.getQueueName(),
+                         ((Queue) receivedDestination).getQueueName());
+        }
+        finally
+        {
+            connection.close();
+        }
+    }
+
+    @Test
+    public void messageSentToTopicComesBackWithTheSameJMSDestination() throws Exception
+    {
+        Topic topic = createTopic(getTestName());
+        Connection connection = getConnection();
+        try
+        {
+            Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+            MessageConsumer consumer = session.createConsumer(topic);
+
+            Utils.sendMessages(session, topic, 1);
+
+            connection.start();
+
+            Message receivedMessage = consumer.receive(getReceiveTimeout());
+            assertNotNull("Message should not be null", receivedMessage);
+
+            Destination receivedDestination = receivedMessage.getJMSDestination();
+
+            assertNotNull("JMSDestination should not be null", receivedDestination);
+            assertTrue("Unexpected destination type", receivedDestination instanceof Topic);
+            assertEquals("Unexpected destination name",
+                         topic.getTopicName(),
+                         ((Topic) receivedDestination).getTopicName());
+        }
+        finally
+        {
+            connection.close();
+        }
+    }
+
+    @Test
+    public void messageSentToQueueComesBackWithTheSameJMSDestinationWhenReceivedAsynchronously() throws Exception
+    {
+        Queue queue = createQueue(getTestName());
+        Connection connection = getConnection();
+        try
+        {
+            Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+            MessageConsumer consumer = session.createConsumer(queue);
+
+            Utils.sendMessages(session, queue, 1);
+
+            connection.start();
+
+            CountDownLatch receiveLatch = new CountDownLatch(1);
+            AtomicReference<Message> messageHolder = new AtomicReference<>();
+            consumer.setMessageListener(message -> {
+                messageHolder.set(message);
+                receiveLatch.countDown();
+            });
+            assertTrue("Timed out waiting for message to be received ",
+                       receiveLatch.await(getReceiveTimeout(), TimeUnit.MILLISECONDS));
+            assertNotNull("Message should not be null", messageHolder.get());
+
+            Destination receivedDestination = messageHolder.get().getJMSDestination();
+
+            assertNotNull("JMSDestination should not be null", receivedDestination);
+            assertTrue("Unexpected destination type", receivedDestination instanceof Queue);
+            assertEquals("Unexpected destination name",
+                         queue.getQueueName(),
+                         ((Queue) receivedDestination).getQueueName());
+        }
+        finally
+        {
+            connection.close();
+        }
+    }
+
+    @Test
+    public void testReceiveResend() throws Exception
+    {
+        Queue queue = createQueue(getTestName());
+        Connection connection = getConnection();
+        try
+        {
+            Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+            MessageConsumer consumer = session.createConsumer(queue);
+
+            Utils.sendMessages(session, queue, 1);
+
+            connection.start();
+
+            Message receivedMessage = consumer.receive(getReceiveTimeout());
+            assertNotNull("Message should not be null", receivedMessage);
+
+            Destination receivedDestination = receivedMessage.getJMSDestination();
+
+            assertNotNull("JMSDestination should not be null", receivedDestination);
+            assertTrue("Unexpected destination type", receivedDestination instanceof Queue);
+            assertEquals("Unexpected destination name",
+                         queue.getQueueName(),
+                         ((Queue) receivedDestination).getQueueName());
+
+            MessageProducer producer = session.createProducer(queue);
+            producer.send(receivedMessage);
+
+            Message message = consumer.receive(getReceiveTimeout());
+            assertNotNull("Message should not be null", message);
+
+            Destination destination = message.getJMSDestination();
+
+            assertNotNull("JMSDestination should not be null", destination);
+            assertTrue("Unexpected destination type", destination instanceof Queue);
+            assertEquals("Unexpected destination name",
+                         queue.getQueueName(),
+                         ((Queue) destination).getQueueName());
+        }
+        finally
+        {
+            connection.close();
+        }
+    }
+}

http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/4ac36ca5/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSReplyToTest.java
----------------------------------------------------------------------
diff --git a/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSReplyToTest.java b/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSReplyToTest.java
new file mode 100644
index 0000000..b30c136
--- /dev/null
+++ b/systests/qpid-systests-jms_1.1/src/test/java/org/apache/qpid/systests/jms_1_1/message/JMSReplyToTest.java
@@ -0,0 +1,128 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.qpid.systests.jms_1_1.message;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+
+import java.util.concurrent.atomic.AtomicReference;
+
+import javax.jms.Connection;
+import javax.jms.Destination;
+import javax.jms.JMSException;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Queue;
+import javax.jms.Session;
+import javax.jms.TemporaryQueue;
+
+import org.junit.Test;
+
+import org.apache.qpid.systests.JmsTestBase;
+
+public class JMSReplyToTest extends JmsTestBase
+{
+    @Test
+    public void testRequestResponseUsingJmsReplyTo() throws Exception
+    {
+        Queue requestQueue = createQueue(getTestName() + ".request");
+        Queue replyToQueue = createQueue(getTestName() + ".reply");
+        Connection connection = getConnection();
+        try
+        {
+            AtomicReference<Throwable> exceptionHolder = createAsynchronousConsumer(connection, requestQueue);
+            connection.start();
+            Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+            MessageConsumer replyConsumer = session.createConsumer(replyToQueue);
+
+            Message requestMessage = session.createTextMessage("Request");
+            requestMessage.setJMSReplyTo(replyToQueue);
+            MessageProducer producer = session.createProducer(requestQueue);
+            producer.send(requestMessage);
+
+            Message responseMessage = replyConsumer.receive(getReceiveTimeout());
+            assertNotNull("Response message not received", responseMessage);
+            assertEquals("Correlation id of the response should match message id of the request",
+                         responseMessage.getJMSCorrelationID(), requestMessage.getJMSMessageID());
+            assertNull("Unexpected exception in responder", exceptionHolder.get());
+        }
+        finally
+        {
+            connection.close();
+        }
+    }
+
+    @Test
+    public void testRequestResponseUsingTemporaryJmsReplyTo() throws Exception
+    {
+        Queue requestQueue = createQueue(getTestName() + ".request");
+        Connection connection = getConnection();
+        try
+        {
+            AtomicReference<Throwable> exceptionHolder = createAsynchronousConsumer(connection, requestQueue);
+            connection.start();
+            Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+            TemporaryQueue replyToQueue = session.createTemporaryQueue();
+
+            MessageConsumer replyConsumer = session.createConsumer(replyToQueue);
+
+            Message requestMessage = session.createTextMessage("Request");
+            requestMessage.setJMSReplyTo(replyToQueue);
+            MessageProducer producer = session.createProducer(requestQueue);
+            producer.send(requestMessage);
+
+            Message responseMessage = replyConsumer.receive(getReceiveTimeout());
+            assertNotNull("Response message not received", responseMessage);
+            assertEquals("Correlation id of the response should match message id of the request",
+                         responseMessage.getJMSCorrelationID(), requestMessage.getJMSMessageID());
+            assertNull("Unexpected exception in responder", exceptionHolder.get());
+        }
+        finally
+        {
+            connection.close();
+        }
+    }
+
+    private AtomicReference<Throwable> createAsynchronousConsumer(Connection connection, Queue requestQueue)
+            throws JMSException
+    {
+        final Session responderSession = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        final AtomicReference<Throwable> caughtException = new AtomicReference<>();
+        final MessageConsumer requestConsumer = responderSession.createConsumer(requestQueue);
+        requestConsumer.setMessageListener(message -> {
+            try
+            {
+                Destination replyTo = message.getJMSReplyTo();
+                MessageProducer responseProducer = responderSession.createProducer(replyTo);
+                Message responseMessage = responderSession.createMessage();
+                responseMessage.setJMSCorrelationID(message.getJMSMessageID());
+                responseProducer.send(responseMessage);
+            }
+            catch (Throwable t)
+            {
+                caughtException.set(t);
+            }
+        });
+        return caughtException;
+    }
+}

http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/4ac36ca5/systests/src/test/java/org/apache/qpid/test/client/message/JMSDestinationTest.java
----------------------------------------------------------------------
diff --git a/systests/src/test/java/org/apache/qpid/test/client/message/JMSDestinationTest.java b/systests/src/test/java/org/apache/qpid/test/client/message/JMSDestinationTest.java
index 5101e68..1fcc494 100644
--- a/systests/src/test/java/org/apache/qpid/test/client/message/JMSDestinationTest.java
+++ b/systests/src/test/java/org/apache/qpid/test/client/message/JMSDestinationTest.java
@@ -20,19 +20,14 @@
  */
 package org.apache.qpid.test.client.message;
 
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
-
 import javax.jms.Connection;
 import javax.jms.Destination;
 import javax.jms.JMSException;
 import javax.jms.Message;
 import javax.jms.MessageConsumer;
-import javax.jms.MessageListener;
 import javax.jms.MessageProducer;
 import javax.jms.Queue;
 import javax.jms.Session;
-import javax.jms.Topic;
 
 import org.apache.qpid.client.AMQDestination;
 import org.apache.qpid.client.CustomJMSXProperty;
@@ -51,9 +46,6 @@ public class JMSDestinationTest extends QpidBrokerTestCase
     private Connection _connection;
     private Session _session;
 
-    private CountDownLatch _receiveMessage;
-    private Message _message;
-
     @Override
     public void setUp() throws Exception
     {
@@ -65,100 +57,6 @@ public class JMSDestinationTest extends QpidBrokerTestCase
     }
 
     /**
-     * Test a message sent to a queue comes back with JMSDestination queue
-     *
-     * @throws Exception
-     */
-    public void testQueue() throws Exception
-    {
-
-        Queue queue = createTestQueue(_session);
-
-        MessageConsumer consumer = _session.createConsumer(queue);
-
-        sendMessage(_session, queue, 1);
-
-        _connection.start();
-
-        Message receivedMessage = consumer.receive(10000);
-
-        assertNotNull("Message should not be null", receivedMessage);
-
-        Destination receivedDestination = receivedMessage.getJMSDestination();
-
-        assertNotNull("JMSDestination should not be null", receivedDestination);
-
-        assertEquals("Incorrect Destination type", queue.getClass(), receivedDestination.getClass());
-    }
-
-    /**
-     * Test a message sent to a topic comes back with JMSDestination topic
-     *
-     * @throws Exception
-     */
-    public void testTopic() throws Exception
-    {
-
-        Topic topic = createTopic(_connection, getTestQueueName() + "Topic");
-
-        MessageConsumer consumer = _session.createConsumer(topic);
-
-        sendMessage(_session, topic, 1);
-
-        _connection.start();
-
-        Message receivedMessage = consumer.receive(10000);
-
-        assertNotNull("Message should not be null", receivedMessage);
-
-        Destination receivedDestination = receivedMessage.getJMSDestination();
-
-        assertNotNull("JMSDestination should not be null", receivedDestination);
-        assertEquals("Incorrect Destination type", topic.getClass(), receivedDestination.getClass());
-    }
-
-    /**
-     * Test a message sent to a queue comes back with JMSDestination queue
-     * when received via a message listener
-     *
-     * @throws Exception
-     */
-    public void testQueueAsync() throws Exception
-    {
-
-        Queue queue = createTestQueue(_session);
-
-        MessageConsumer consumer = _session.createConsumer(queue);
-
-        sendMessage(_session, queue, 1);
-
-        _connection.start();
-
-        _message = null;
-        _receiveMessage = new CountDownLatch(1);
-
-        consumer.setMessageListener(new MessageListener()
-        {
-            @Override
-            public void onMessage(Message message)
-            {
-                _message = message;
-                _receiveMessage.countDown();
-            }
-        });
-
-        assertTrue("Timed out waiting for message to be received ", _receiveMessage.await(1, TimeUnit.SECONDS));
-
-        assertNotNull("Message should not be null", _message);
-
-        Destination receivedDestination = _message.getJMSDestination();
-
-        assertNotNull("JMSDestination should not be null", receivedDestination);
-
-        assertEquals("Incorrect Destination type", queue.getClass(), receivedDestination.getClass());
-    }
-
-    /**
      * Test a message received without the JMS_QPID_DESTTYPE can be resent
      * and correctly have the property set.
      *

http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/4ac36ca5/systests/src/test/java/org/apache/qpid/test/client/message/JMSReplyToTest.java
----------------------------------------------------------------------
diff --git a/systests/src/test/java/org/apache/qpid/test/client/message/JMSReplyToTest.java b/systests/src/test/java/org/apache/qpid/test/client/message/JMSReplyToTest.java
deleted file mode 100644
index 88594f6..0000000
--- a/systests/src/test/java/org/apache/qpid/test/client/message/JMSReplyToTest.java
+++ /dev/null
@@ -1,169 +0,0 @@
-/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
- */
-package org.apache.qpid.test.client.message;
-
-import java.util.concurrent.atomic.AtomicReference;
-
-import javax.jms.Connection;
-import javax.jms.Destination;
-import javax.jms.IllegalStateException;
-import javax.jms.JMSException;
-import javax.jms.Message;
-import javax.jms.MessageConsumer;
-import javax.jms.MessageListener;
-import javax.jms.MessageProducer;
-import javax.jms.Queue;
-import javax.jms.Session;
-import javax.jms.TemporaryQueue;
-
-import org.apache.qpid.test.utils.QpidBrokerTestCase;
-
-/**
- * Tests that {@link Message#setJMSReplyTo(Destination)} can be used to pass a {@link Destination} between
- * messaging clients as is commonly used in request/response messaging pattern implementations.
- */
-public class JMSReplyToTest extends QpidBrokerTestCase
-{
-    private AtomicReference<Throwable> _caughtException = new AtomicReference<Throwable>();
-    private Queue _requestQueue;
-    private Connection _connection;
-    private Session _session;
-
-    @Override
-    protected void setUp() throws Exception
-    {
-        super.setUp();
-
-        _requestQueue = startAsyncRespondingJmsConsumerOnSeparateConnection();
-
-        _connection = getConnection();
-        _connection.start();
-        _session = _connection.createSession(false,  Session.AUTO_ACKNOWLEDGE);
-    }
-
-    public void testRequestResponseUsingJmsReplyTo() throws Exception
-    {
-        final String responseQueueName = getTestQueueName() + ".response";
-        Queue replyToQueue = createTestQueue(_session, responseQueueName);
-        sendRequestAndValidateResponse(replyToQueue);
-    }
-
-    public void testRequestResponseUsingTemporaryJmsReplyTo() throws Exception
-    {
-        TemporaryQueue replyToQueue = _session.createTemporaryQueue();
-
-        sendRequestAndValidateResponse(replyToQueue);
-    }
-
-    private void sendRequestAndValidateResponse(Queue replyToQueue) throws JMSException, Exception
-    {
-        MessageConsumer replyConsumer = _session.createConsumer(replyToQueue);
-
-        Message requestMessage = createRequestMessageWithJmsReplyTo(_session, replyToQueue);
-        sendRequest(_requestQueue, _session, requestMessage);
-
-        receiveAndValidateResponse(replyConsumer, requestMessage);
-
-        assertNull("Async responder caught unexpected exception", _caughtException.get());
-    }
-
-    private Message createRequestMessageWithJmsReplyTo(Session session, Queue replyToQueue)
-            throws JMSException
-    {
-        Message requestMessage = session.createTextMessage("My request");
-        requestMessage.setJMSReplyTo(replyToQueue);
-        return requestMessage;
-    }
-
-    private void sendRequest(final Queue requestQueue, Session session, Message requestMessage) throws Exception
-    {
-        MessageProducer producer = session.createProducer(requestQueue);
-        producer.send(requestMessage);
-    }
-
-    private void receiveAndValidateResponse(MessageConsumer replyConsumer, Message requestMessage) throws JMSException
-    {
-        Message responseMessage = replyConsumer.receive(RECEIVE_TIMEOUT);
-        assertNotNull("Response message not received", responseMessage);
-        assertEquals("Correlation id of the response should match message id of the request",
-                responseMessage.getJMSCorrelationID(), requestMessage.getJMSMessageID());
-    }
-
-    private Queue startAsyncRespondingJmsConsumerOnSeparateConnection() throws Exception
-    {
-        final String requestQueueName = getTestQueueName() + ".request";
-        final Connection responderConnection =  getConnection();
-        responderConnection.start();
-        final Session responderSession = responderConnection.createSession(false, Session.AUTO_ACKNOWLEDGE);
-        final Queue requestQueue = createTestQueue(responderSession, requestQueueName);
-
-        final MessageConsumer requestConsumer = responderSession.createConsumer(requestQueue);
-        requestConsumer.setMessageListener(new AsyncResponder(responderSession));
-
-        return requestQueue;
-    }
-
-    private final class AsyncResponder implements MessageListener
-    {
-        private final Session _responderSession;
-
-        private AsyncResponder(Session responderSession)
-        {
-            _responderSession = responderSession;
-        }
-
-        @Override
-        public void onMessage(Message requestMessage)
-        {
-            try
-            {
-                Destination replyTo = getReplyToQueue(requestMessage);
-
-                Message responseMessage = _responderSession.createMessage();
-                responseMessage.setJMSCorrelationID(requestMessage.getJMSMessageID());
-
-                sendResponseToQueue(replyTo, responseMessage);
-            }
-            catch (Throwable t)
-            {
-                _caughtException.set(t);
-            }
-        }
-
-        private Destination getReplyToQueue(Message requestMessage) throws JMSException, IllegalStateException
-        {
-            Destination replyTo = requestMessage.getJMSReplyTo();
-            if (replyTo == null)
-            {
-                throw new IllegalStateException("JMSReplyTo was null on message " + requestMessage);
-            }
-            return replyTo;
-        }
-
-        private void sendResponseToQueue(Destination replyTo, Message responseMessage)
-                throws JMSException
-        {
-            MessageProducer responseProducer = _responderSession.createProducer(replyTo);
-            responseProducer.send(responseMessage);
-        }
-    }
-
-}

http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/4ac36ca5/test-profiles/cpp.excludes
----------------------------------------------------------------------
diff --git a/test-profiles/cpp.excludes b/test-profiles/cpp.excludes
index b8cbd4b..d41d8fe 100644
--- a/test-profiles/cpp.excludes
+++ b/test-profiles/cpp.excludes
@@ -21,9 +21,6 @@
 //Exclude the following tests when running all cpp test profilies
 //======================================================================
 
-// This test requires a management interface to move messages
-org.apache.qpid.test.client.message.JMSDestinationTest#testMovedToQueue
-
 // This test requires a broker capable of 0-8/9 and 0-10
 org.apache.qpid.test.client.message.JMSDestinationTest#testReceiveResend
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org