You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2015/09/25 00:49:05 UTC
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/71
Cordova-Android 5.0/Marshmallow Updates
This one had to be re-written because of our workflow. The PHONE_STATE permission needs to be removed in favour of AudioFocus
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-plugin-media smores
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 45113294cea104ad99ade7857797073bef44d622
Author: Joe Bowser <bo...@apache.org>
Date: 2015-09-24T18:17:39Z
Adding engine tag
commit 8d2dad550ae1b253e0320dcb06f0e40386152710
Author: Joe Bowser <bo...@apache.org>
Date: 2015-09-24T22:46:24Z
Adding the media permissions code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170559
--- Diff: src/android/AudioHandler.java ---
@@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under one
private int origVolumeStream = -1;
private CallbackContext messageChannel;
+
+ public static String [] permissions = { Manifest.permission.RECORD_AUDIO, Manifest.permission.WRITE_EXTERNAL_STORAGE};
+ public static int RECORD_AUDIO = 0;
+ public static int WRITE_EXTERNAL_STORAGE = 1;
+
+ public static final int PERMISSION_DENIED_ERROR = 20;
--- End diff --
Does the magic number need to be documented? I'm not very familiar with error handling and how Cordova deals with error codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#issuecomment-152604611
Rebased, Closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170726
--- Diff: src/android/AudioHandler.java ---
@@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under one
private int origVolumeStream = -1;
private CallbackContext messageChannel;
+
+ public static String [] permissions = { Manifest.permission.RECORD_AUDIO, Manifest.permission.WRITE_EXTERNAL_STORAGE};
--- End diff --
These fields below should ideally be private
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org