You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/10/13 23:55:12 UTC
[GitHub] [druid] a2l007 opened a new pull request #11798: S3 Ingestion from non-default endpoints
a2l007 opened a new pull request #11798:
URL: https://github.com/apache/druid/pull/11798
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
`S3InputSource` presently provides an option to override the default S3 credentials which is useful to read from different buckets, but it has to be in the same endpoint. This PR adds functionality to specify a different endpoint and associated client properties as part of the `S3InputSource` spec. This can be helpful for operators looking to migrate data from one store to another. This is implemented only for S3 at the moment, but we can support other cloud providers as a followup.
##### Key changed/added classes in this PR
* `S3InputSource`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a change in pull request #11798: S3 Ingestion from non-default endpoints
Posted by GitBox <gi...@apache.org>.
cryptoe commented on a change in pull request #11798:
URL: https://github.com/apache/druid/pull/11798#discussion_r728639973
##########
File path: docs/ingestion/native-batch.md
##########
@@ -943,13 +943,55 @@ Sample specs:
},
...
```
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"],
+ "endpointConfig": {
+ "url" : "s3-store.aws.com",
+ "signingRegion" : "us-west-2"
+ },
+ "clientConfig": {
+ "protocol" : "http",
+ "disableChunkedEncoding" : true,
+ "enablePathStyleAccess" : true,
+ "forceGlobalBucketAccessEnabled" : false
+ },
+
+ "proxyConfig": {
+ "host" : "proxy-s3.aws.com",
+ "port" : 8888,
+ "username" : "admin",
+ "password" : "admin"
+ },
+
+ "properties": {
+ "accessKeyId": "KLJ78979SDFdS2",
Review comment:
Replace with xxxx or something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] a2l007 commented on a change in pull request #11798: S3 Ingestion from non-default endpoints
Posted by GitBox <gi...@apache.org>.
a2l007 commented on a change in pull request #11798:
URL: https://github.com/apache/druid/pull/11798#discussion_r730138798
##########
File path: docs/ingestion/native-batch.md
##########
@@ -943,13 +943,55 @@ Sample specs:
},
...
```
+```json
+...
+ "ioConfig": {
+ "type": "index_parallel",
+ "inputSource": {
+ "type": "s3",
+ "uris": ["s3://foo/bar/file.json", "s3://bar/foo/file2.json"],
+ "endpointConfig": {
+ "url" : "s3-store.aws.com",
+ "signingRegion" : "us-west-2"
+ },
+ "clientConfig": {
+ "protocol" : "http",
+ "disableChunkedEncoding" : true,
+ "enablePathStyleAccess" : true,
+ "forceGlobalBucketAccessEnabled" : false
+ },
+
+ "proxyConfig": {
+ "host" : "proxy-s3.aws.com",
+ "port" : 8888,
+ "username" : "admin",
+ "password" : "admin"
+ },
+
+ "properties": {
+ "accessKeyId": "KLJ78979SDFdS2",
Review comment:
Thanks for taking a look. These are fake credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org