You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/09/12 02:40:57 UTC

Review Request 38327: Added workaround for rmdir after umount in LinuxFilesystemIsolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38327/
-----------------------------------------------------------

Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-3349
    https://issues.apache.org/jira/browse/MESOS-3349


Repository: mesos


Description
-------

Added workaround for rmdir after umount in LinuxFilesystemIsolator.


Diffs
-----

  src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 

Diff: https://reviews.apache.org/r/38327/diff/


Testing
-------

sudo make check on Centos5.


Thanks,

Jie Yu


Re: Review Request 38327: Added workaround for rmdir after umount in LinuxFilesystemIsolator.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38327/#review98728
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Sept. 12, 2015, 12:40 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38327/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 12:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3349
>     https://issues.apache.org/jira/browse/MESOS-3349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added workaround for rmdir after umount in LinuxFilesystemIsolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
> 
> Diff: https://reviews.apache.org/r/38327/diff/
> 
> 
> Testing
> -------
> 
> sudo make check on Centos5.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 38327: Added workaround for rmdir after umount in LinuxFilesystemIsolator.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38327/#review98729
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38327]

All tests passed.

- Mesos ReviewBot


On Sept. 12, 2015, 12:40 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38327/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 12:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3349
>     https://issues.apache.org/jira/browse/MESOS-3349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added workaround for rmdir after umount in LinuxFilesystemIsolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
> 
> Diff: https://reviews.apache.org/r/38327/diff/
> 
> 
> Testing
> -------
> 
> sudo make check on Centos5.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>