Change what gets logged when service is disabled

[Shawn Heisey <so...@elyograg.org>]

  I use the PingRequestHandler option that tells my load balancer 
whether a machine is available.

When the service is disabled, every one of those requests, which my load 
balancer makes every five seconds, results in the following in the log:

Sep 9, 2010 6:06:58 PM org.apache.solr.common.SolrException log
SEVERE: org.apache.solr.common.SolrException: Service disabled
         at 
org.apache.solr.handler.PingRequestHandler.handleRequestBody(PingRequestHandler.java:48)
         at 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:131)
         at org.apache.solr.core.SolrCore.execute(SolrCore.java:1316)
         at 
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:338)
         at 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:241)
         at 
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
         at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
         at 
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
         at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
         at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
         at 
org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
         at 
org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
         at 
org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
         at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
         at org.mortbay.jetty.Server.handle(Server.java:326)
         at 
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
         at 
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:923)
         at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:547)
         at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
         at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
         at 
org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
         at 
org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:451)

This seems highly excessive, especially for something that I did on 
purpose.  I run with logging at WARN.  Would it make sense to change 
this to an INFO or DEBUG and eliminate the stack trace?  I have minimal 
Java skills, but I am passable with other languages.  Would it be hard 
to find and fix this in the code, given that limitation?

Ultimately I think the severity of this log message should be 
configurable.  I do not think the stack trace is at all helpful, but I 
suppose some people might want a knob to turn that on and off as well.

Thanks,
Shawn

Re: Change what gets logged when service is disabled

[Chris Hostetter <ho...@fucit.org>]

:  I use the PingRequestHandler option that tells my load balancer whether a
: machine is available.
: 
: When the service is disabled, every one of those requests, which my load
: balancer makes every five seconds, results in the following in the log:
: 
: Sep 9, 2010 6:06:58 PM org.apache.solr.common.SolrException log
: SEVERE: org.apache.solr.common.SolrException: Service disabled
	...
: This seems highly excessive, especially for something that I did on purpose.
: I run with logging at WARN.  Would it make sense to change this to an INFO or
: DEBUG and eliminate the stack trace?  I have minimal Java skills, but I am

...ugh.  this is terrible. 

: Ultimately I think the severity of this log message should be configurable.  I

I think you are being two generous.  the purpose of this handler is to 
throw that exception to get that status code so the status code can be 
propogated -- it shouldn't even be logged as a problem.  

The PingHandler even has code to prevent this ( there is an option on the 
Exception to indicate that it's already been logged) but evidently that 
isn't being respected further up the chain.

Thanks for pointing this out, i've opened a ticket...

https://issues.apache.org/jira/browse/SOLR-2124



-Hoss

--
http://lucenerevolution.org/  ...  October 7-8, Boston
http://bit.ly/stump-hoss      ...  Stump The Chump!