You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@s2graph.apache.org by 정희원 <hw...@nemustech.com> on 2018/10/08 06:42:55 UTC
Step limit bug(?) in getEdges API
Good morning.
I have a question about using s2graph.
In the getEdges request body, limit works as follows.
I wonder if I'm using it wrong or a bug
Using version 0.2.0
Enter data as example.sh
Three "friends" in "Elmo" (offset: 0, limit: 3) => Only two results are displayed.
If offset is 1, 3 results are returned.
If you look at the code, there is a code that compensates the limit when the offset is 0, but it does not seem to work normally.
Thank you for your guide.
Thank you.
-----------------------------------------------------------------------------------------------------------------------------------
안녕하세요.
s2graph 사용중에 궁금한 점이 있어서 문의 드립니다.
getEdges request body에 limit 아래와 같이 동작합니다.
제가 잘못 사용하고 있는 것인지 버그인지 궁금합니다
0.2.0 버전 사용 중
example.sh로 data 입력
"Elmo"의 "friends"를 3개 조회(offset:0, limit:3) => 결과가 2개만 조회됨.
offset을 1로 하는 경우는 3개가 조회됨.
code를 보니 offset이 0인 경우에 보정하는 code가 있지만 정상동작을 하지 않는 것 같습니다.
그럼 가이드 부탁 드립니다.
감사합니다.
이 메일은 나눔글꼴로 작성되었습니다. 설치하기
정희원 JUNG HeeWon
H3
06212 서울시 강남구 선릉로85길 8, 2층 (역삼동, 유화빌딩)
Mobile 010-8518-0657
Email hwjung@nemustech.com
Re: Step limit bug(?) in getEdges API
Posted by daewon <da...@apache.org>.
I created a jira issue that corresponds to the reported bug.
https://issues.apache.org/jira/browse/S2GRAPH-243
2018년 10월 8일 (월) 오후 9:58, DO YUNG YOON <sh...@gmail.com>님이 작성:
> Hi HeeWon.
>
> Welcome to s2graph and thanks for asking this question.
>
> I think it is a *bug* since v0.2.0 AsynchbaseStorage did not use the
> correct variables.
> I guess the bug exists on
> https://github.com/apache/incubator-s2graph/blob/v0.2.0-incubating/s2core/src/main/scala/org/apache/s2graph/core/storage/hbase/AsynchbaseStorage.scala#L408
>
> I believe that QueryParam instance's innerOffset, innerLimit variable
> should be used on ColumnPaginationFilter, instead of using offset, limit
> directly.
>
> It would be great if you can open an issue on JIRA
> <https://issues.apache.org/jira/projects/S2GRAPH/issues/S2GRAPH-240?filter=allopenissues> as
> you described on this thread so you can start getting involved(It would be
> even perfect if you can provide a patch).
>
> Just let you know that our master branch provides GraphQL version of the
> example, which I think much easier to play with(
> https://github.com/apache/incubator-s2graph/tree/master/s2graphql).
>
> After version 0.2.0, we are focusing much more on GraphQL interface, so
> personally, if you are starting to playing around with S2Graph, then I
> recommend using GraphQL version.
>
> Best Regards.
> Doyung Yoon
>
> On Mon, Oct 8, 2018 at 3:43 PM 정희원 <hw...@nemustech.com> wrote:
>
>> Good morning.
>>
>> I have a question about using s2graph.
>>
>> In the getEdges request body, limit works as follows.
>> I wonder if I'm using it wrong or a bug
>>
>>
>> - Using version 0.2.0
>> - Enter data as example.sh
>> -
>> Three "friends" in "Elmo" (offset: 0, limit: 3) => Only two results are displayed.
>>
>> - If offset is 1, 3 results are returned.
>>
>> - If you look at the code, there is a code that compensates the
>> limit when the offset is 0, but it does not seem to work normally.
>>
>>
>> Thank you for your guide.
>>
>> Thank you.
>>
>> ------------------------------------------------------------------------
>> -----------------------------------------------------------
>>
>> 안녕하세요.
>>
>> s2graph 사용중에 궁금한 점이 있어서 문의 드립니다.
>>
>> getEdges request body에 limit 아래와 같이 동작합니다.
>> 제가 잘못 사용하고 있는 것인지 버그인지 궁금합니다
>>
>>
>> - 0.2.0 버전 사용 중
>> - example.sh로 data 입력
>> - "Elmo"의 "friends"를 3개 조회(offset:0, limit:3) => 결과가 2개만 조회됨.
>>
>> - offset을 1로 하는 경우는 3개가 조회됨.
>>
>> - code를 보니 offset이 0인 경우에 보정하는 code가 있지만 정상동작을 하지 않는 것 같습니다.
>>
>>
>> 그럼 가이드 부탁 드립니다.
>>
>> 감사합니다.
>>
>> 이 메일은 나눔글꼴로 작성되었습니다. 설치하기 <http://hangeul.naver.com>
>>
>> *정희원* JUNG HeeWon
>> H3
>>
>> 06212 서울시 강남구 선릉로85길 8, 2층
>> <https://maps.google.com/?q=%EC%84%9C%EC%9A%B8%EC%8B%9C+%EA%B0%95%EB%82%A8%EA%B5%AC+%EC%84%A0%EB%A6%89%EB%A1%9C85%EA%B8%B8+8,+2%EC%B8%B5&entry=gmail&source=g>
>> (역삼동, 유화빌딩)
>> *Mobile *010-8518-0657
>> *Email *hwjung@nemustech.com
>>
>> <#m_3634200468006205536_m_-6105833782450742032_>
>>
>
Re: Step limit bug(?) in getEdges API
Posted by DO YUNG YOON <sh...@gmail.com>.
Hi HeeWon.
Welcome to s2graph and thanks for asking this question.
I think it is a *bug* since v0.2.0 AsynchbaseStorage did not use the
correct variables.
I guess the bug exists on
https://github.com/apache/incubator-s2graph/blob/v0.2.0-incubating/s2core/src/main/scala/org/apache/s2graph/core/storage/hbase/AsynchbaseStorage.scala#L408
I believe that QueryParam instance's innerOffset, innerLimit variable
should be used on ColumnPaginationFilter, instead of using offset, limit
directly.
It would be great if you can open an issue on JIRA
<https://issues.apache.org/jira/projects/S2GRAPH/issues/S2GRAPH-240?filter=allopenissues>
as
you described on this thread so you can start getting involved(It would be
even perfect if you can provide a patch).
Just let you know that our master branch provides GraphQL version of the
example, which I think much easier to play with(
https://github.com/apache/incubator-s2graph/tree/master/s2graphql).
After version 0.2.0, we are focusing much more on GraphQL interface, so
personally, if you are starting to playing around with S2Graph, then I
recommend using GraphQL version.
Best Regards.
Doyung Yoon
On Mon, Oct 8, 2018 at 3:43 PM 정희원 <hw...@nemustech.com> wrote:
> Good morning.
>
> I have a question about using s2graph.
>
> In the getEdges request body, limit works as follows.
> I wonder if I'm using it wrong or a bug
>
>
> - Using version 0.2.0
> - Enter data as example.sh
> -
> Three "friends" in "Elmo" (offset: 0, limit: 3) => Only two results are displayed.
>
> - If offset is 1, 3 results are returned.
>
> - If you look at the code, there is a code that compensates the limit
> when the offset is 0, but it does not seem to work normally.
>
>
> Thank you for your guide.
>
> Thank you.
>
> ------------------------------------------------------------------------
> -----------------------------------------------------------
>
> 안녕하세요.
>
> s2graph 사용중에 궁금한 점이 있어서 문의 드립니다.
>
> getEdges request body에 limit 아래와 같이 동작합니다.
> 제가 잘못 사용하고 있는 것인지 버그인지 궁금합니다
>
>
> - 0.2.0 버전 사용 중
> - example.sh로 data 입력
> - "Elmo"의 "friends"를 3개 조회(offset:0, limit:3) => 결과가 2개만 조회됨.
>
> - offset을 1로 하는 경우는 3개가 조회됨.
>
> - code를 보니 offset이 0인 경우에 보정하는 code가 있지만 정상동작을 하지 않는 것 같습니다.
>
>
> 그럼 가이드 부탁 드립니다.
>
> 감사합니다.
>
> 이 메일은 나눔글꼴로 작성되었습니다. 설치하기 <http://hangeul.naver.com>
>
> *정희원* JUNG HeeWon
> H3
>
> 06212 서울시 강남구 선릉로85길 8, 2층
> <https://maps.google.com/?q=%EC%84%9C%EC%9A%B8%EC%8B%9C+%EA%B0%95%EB%82%A8%EA%B5%AC+%EC%84%A0%EB%A6%89%EB%A1%9C85%EA%B8%B8+8,+2%EC%B8%B5&entry=gmail&source=g>
> (역삼동, 유화빌딩)
> *Mobile *010-8518-0657
> *Email *hwjung@nemustech.com
>
> <#m_-6105833782450742032_>
>