You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sc...@coverity.com on 2015/03/16 10:56:00 UTC
New Defects reported by Coverity Scan for cloudstack
Hi,
Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan.
47 new defect(s) introduced to cloudstack found with Coverity Scan.
590 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 47 defect(s)
** CID 1288552: Null pointer dereferences (NULL_RETURNS)
/server/src/com/cloud/network/NetworkUsageManagerImpl.java: 147 in com.cloud.network.NetworkUsageManagerImpl.addTrafficMonitor(org.apache.cloudstack.api.command.admin.usage.AddTrafficMonitorCmd)()
________________________________________________________________________________________________________
*** CID 1288552: Null pointer dereferences (NULL_RETURNS)
/server/src/com/cloud/network/NetworkUsageManagerImpl.java: 147 in com.cloud.network.NetworkUsageManagerImpl.addTrafficMonitor(org.apache.cloudstack.api.command.admin.usage.AddTrafficMonitorCmd)()
141 throw new InvalidParameterValueException("Could not find zone with ID: " + zoneId);
142 } else {
143 zoneName = zone.getName();
144 }
145
146 List<HostVO> trafficMonitorsInZone = _resourceMgr.listAllHostsInOneZoneByType(Host.Type.TrafficMonitor, zoneId);
>>> CID 1288552: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "trafficMonitorsInZone".
147 if (trafficMonitorsInZone.size() != 0) {
148 throw new InvalidParameterValueException("Already added an traffic monitor in zone: " + zoneName);
149 }
150
151 URI uri;
152 try {
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/943?tab=overview
To manage Coverity Scan email notifications for "dev@cloudstack.apache.org", click https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org&token=494aabd5ba647999fa41b6d766646231 .
Re: New Defects reported by Coverity Scan for cloudstack
Posted by Daan Hoogland <da...@gmail.com>.
Guys `n' dolls,
good and bad news here ; the good first
590 issues were fixed and only 47 newly discovered.
bad news :
in spite of 590 fixed issues 47 new ones were introduced. So anybody
that did any checkin over the last month or so, please have a look and
see if these are false positives or your solutions could have been
implemented more savely.
I take it we all want to make sure no programmer traps are included in
our fine product.
thanks,
On Mon, Mar 16, 2015 at 10:56 AM, <sc...@coverity.com> wrote:
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan.
>
> 47 new defect(s) introduced to cloudstack found with Coverity Scan.
> 590 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
>
> New defect(s) Reported-by: Coverity Scan
> Showing 20 of 47 defect(s)
>
>
> ** CID 1288552: Null pointer dereferences (NULL_RETURNS)
> /server/src/com/cloud/network/NetworkUsageManagerImpl.java: 147 in com.cloud.network.NetworkUsageManagerImpl.addTrafficMonitor(org.apache.cloudstack.api.command.admin.usage.AddTrafficMonitorCmd)()
>
>
> ________________________________________________________________________________________________________
> *** CID 1288552: Null pointer dereferences (NULL_RETURNS)
> /server/src/com/cloud/network/NetworkUsageManagerImpl.java: 147 in com.cloud.network.NetworkUsageManagerImpl.addTrafficMonitor(org.apache.cloudstack.api.command.admin.usage.AddTrafficMonitorCmd)()
> 141 throw new InvalidParameterValueException("Could not find zone with ID: " + zoneId);
> 142 } else {
> 143 zoneName = zone.getName();
> 144 }
> 145
> 146 List<HostVO> trafficMonitorsInZone = _resourceMgr.listAllHostsInOneZoneByType(Host.Type.TrafficMonitor, zoneId);
>>>> CID 1288552: Null pointer dereferences (NULL_RETURNS)
>>>> Calling a method on null object "trafficMonitorsInZone".
> 147 if (trafficMonitorsInZone.size() != 0) {
> 148 throw new InvalidParameterValueException("Already added an traffic monitor in zone: " + zoneName);
> 149 }
> 150
> 151 URI uri;
> 152 try {
>
>
> ________________________________________________________________________________________________________
> To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/943?tab=overview
>
> To manage Coverity Scan email notifications for "dev@cloudstack.apache.org", click https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org&token=494aabd5ba647999fa41b6d766646231 .
>
--
Daan