You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/27 01:42:46 UTC

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions

AlexanderAshitkin commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1057395224


##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -81,6 +81,7 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon
     public static final String CONFIG_PATH_PROPERTY_NAME = "maven.build.cache.configPath";
     public static final String CACHE_ENABLED_PROPERTY_NAME = "maven.build.cache.enabled";
     public static final String CACHE_LOCATION_PROPERTY_NAME = "maven.build.cache.location";
+    public static final String REMOTE_URL_PROPERTY_NAME = "maven.build.cache.remoteUrl";

Review Comment:
   Yes, with this change is to set remote cache url from command line and it's currently used in integration tests to test remote cache interactions using WireMock. The change allows to use using dynamic WireMock ports  to prevent port conflicts in tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org