You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/07/05 13:34:36 UTC
[GitHub] [incubator-mxnet] RafLit opened a new pull request #20419: [FEATURE] np transpose to nd implementation
RafLit opened a new pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419
## Description ##
- deleted the numpy transpose
- moved numpy transpose to ndarray implementation
- speedup of numpy transpose thanks to the ONEdnn transpose operator:
### Transpose operator benchmark results
<table>
<tr>
<td> </ td>
<td colspan=2 align="center"> This PR </ td>
<td colspan=2 align="center"> Master </ td>
</tr>
<tr>
<td> tensor shape </td>
<td> numpy [ms] </ td>
<td> ndarray [ms]</ td>
<td> numpy [ms] </ td>
<td> ndarray [ms] </ td>
</tr>
<tr>
<td> (128, 128)</td>
<td> 0.5742</ td>
<td> 0.5906 </ td>
<td> 0.5274 </ td>
<td> 0.5942 </ td>
</tr>
<tr>
<td> (2048, 2048)</td>
<td> 1.3554</ td>
<td> 1.3458 </ td>
<td> 1.7525 </ td>
<td> 1.3128 </ td>
</tr>
<tr>
<td> (4096, 4096)</td>
<td> 4.6793</ td>
<td> 4.6705 </ td>
<td> 6.0797 </ td>
<td> 4.6172 </ td>
</tr>
<td> (256, 256, 256)</td>
<td> 4.0402</ td>
<td> 3.9367 </ td>
<td> 118.3312 </ td>
<td> 3.9208 </ td>
</tr>
<td> (64, 64, 64, 64)</td>
<td> 4.1867</ td>
<td> 4.2186 </ td>
<td> 137.0017 </ td>
<td> 4.1942 </ td>
</tr>
</table>
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
## Question ##
I also have a question regarding the axes parameter in numpy and ndarray transpose. Numpy axes supports negative indices in the axes parameter, so one can for example use:
```
x = mx.np.arange(20).reshape(2,5,2)
y = mx.np.transpose(x, axes=(-3,-2,-1)
```
and it will work fine, but giving the same axes parameter to ndarray transpose is not supported, so for example:
```
x = mx.nd.arange(20).reshape(2,5,2)
y = mx.nd.transpose(x, axes=(-3,-2,-1))
```
ends with an error.
should support for negative indices be added to ndarray transpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-927377526
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-875455444
@RafLit For non-square matrices, the algorithms are more complicated. Could you tell me whether you have any results for a non-square matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962634218
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-964055148
@szha Could you please review the changes and merge if it's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963853634
Jenkins CI successfully triggered : [unix-cpu, unix-gpu, centos-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876747219
Jenkins CI successfully triggered : [windows-cpu, unix-gpu, miscellaneous, clang, website, centos-cpu, sanity, edge, windows-gpu, centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876294537
> ## Question
> I also have a question regarding the axes parameter in numpy and ndarray transpose. Numpy axes supports negative indices in the axes parameter, so one can for example use:
>
> ```
> x = mx.np.arange(20).reshape(2,5,2)
> y = mx.np.transpose(x, axes=(-3,-2,-1)
> ```
>
> and it will work fine, but giving the same axes parameter to ndarray transpose is not supported, so for example:
>
> ```
> x = mx.nd.arange(20).reshape(2,5,2)
> y = mx.nd.transpose(x, axes=(-3,-2,-1))
> ```
>
> ends with an error.
>
> should support for negative indices be added to ndarray transpose?
I think that mx.nd.transpose(x, axes=(-3,-2,-1)) should be valid, as it is in numpy.
@szha What do you think about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876294481
Jenkins CI successfully triggered : [windows-cpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-886983744
Jenkins CI successfully triggered : [sanity]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-923177245
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962604685
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963140785
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876912196
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963632464
@mxnet-bot run ci [unix-cpu,unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962604701
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel edited a comment on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mozga-intel edited a comment on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-875455444
@RafLit For non-square matrices, the algorithm is more complicated (in-place). Could you tell me whether you have any results for a non-square matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963890537
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963140675
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962588288
Jenkins CI successfully triggered : [unix-cpu, centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962612384
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962634196
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-923907888
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-889826470
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-889826429
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-923907822
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922235760
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876747123
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-923177155
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-888634831
Jenkins CI successfully triggered : [centos-cpu, unix-cpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963633511
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963890561
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] np transpose to nd implementation
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-874119003
Hey @RafLit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, edge, centos-gpu, windows-gpu, unix-cpu, miscellaneous, unix-gpu, windows-cpu, sanity, website, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-888634773
@mxnet-bot run ci [unix-cpu, centos-cpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922780765
Jenkins CI successfully triggered : [windows-gpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922235775
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963853561
@mxnet-bot run ci [centos-cpu, unix-cpu, unix-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962588269
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963873161
Jenkins CI successfully triggered : [centos-cpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922110599
@mxnet-bot run ci [website, windows-gpu, unix-cpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922723018
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] np transpose to nd implementation
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-874119003
Hey @RafLit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, edge, centos-gpu, windows-gpu, unix-cpu, miscellaneous, unix-gpu, windows-cpu, sanity, website, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-886994020
`src/operator/tensor/matrix_op-inl.h:613: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#discussion_r730865615
##########
File path: src/operator/nn/dnnl/dnnl_transpose-inl.h
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file dnnl_transpose-inl.h
+ * \brief
Review comment:
Unnecessary \brief as there is no description after it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876912163
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-886983678
@mxnet-bot run ci [sanity]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-884958436
@RafLit, @szha it’s worth adding that support. Could you please add support for negative axes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922780705
@mxnet-bot run ci [windows-gpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922110637
Jenkins CI successfully triggered : [windows-gpu, centos-gpu, website, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-922722975
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963873103
@mxnet-bot run ci [centos-cpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876246621
> @RafLit For non-square matrices, the algorithm is more complicated (in-place). Could you tell me whether you have any results for a non-square matrix?
@anko-intel I updated the table and added some data for non-square matrices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-876294425
@mxnet-bot run ci [centos-cpu, windows-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-927377543
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963632537
Jenkins CI successfully triggered : [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-962612366
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-963633549
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-889935824
I changed the nd.transpose api, so that "axes=None" instead of "axes=[]" would run the default reversal of axes (like for numpy api):
master:
```
x = mx.nd.arange(24, ctx=mx.cpu()).reshape(2,3,4)
y = mx.nd.transpose(x, axes=[]) # works fine
y = mx.nd.transpose(x, axes=None)
MXNetError: Check failed: std: :max(shp.ndim(), out_shp.ndim()) == param.axes.ndim() (3 vs. -1) :
```
this PR:
```
y = mx.nd.transpose(x, axes=[])
MXNetError: Check failed: std: :max(shape.ndim(), out_shape.ndim()) == param.axes.ndim() (3 vs. 0) : The number of axes does not match the dimension of the tensor.
y = mx.nd.transpose(x, axes=None) # works fine
```
I think this solution is more intuitive and clear. @szha Is this change to the api fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20419: [FEATURE] add oneDNN support for numpy transpose
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20419:
URL: https://github.com/apache/incubator-mxnet/pull/20419#issuecomment-964669552
@bgawrych should be able to help with the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org