You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by guozhangwang <gi...@git.apache.org> on 2016/02/01 22:46:55 UTC

[GitHub] kafka pull request: MINOR: Reorder StreamThread shutdown sequence

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/845

    MINOR: Reorder StreamThread shutdown sequence

    We need to close producer first before closing tasks to make sure all messages are acked and hence checkpoint offsets are updated before closing tasks and their state. It was re-ordered mistakenly before.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka KStreamState

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #845
    
----
commit 5acf1d526a4a2fdcf8d91c582fae8ca014bbadfc
Author: Guozhang Wang <wa...@gmail.com>
Date:   2016-02-01T21:44:59Z

    Re-order close sequence

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: MINOR: Reorder StreamThread shutdown sequence

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/845


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---