You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by ThilinaManamgoda <gi...@git.apache.org> on 2016/06/30 15:33:59 UTC
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
GitHub user ThilinaManamgoda opened a pull request:
https://github.com/apache/incubator-taverna-workbench/pull/5
Taverna 989 : Changed return type to Path
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThilinaManamgoda/incubator-taverna-workbench TAVERNA-989
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-workbench/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit 4c548c8fceebba32532f0e3e068e8ea8d8136dec
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-29T22:25:48Z
testing
commit ed2ab6f13b428414ac7905a62fce14b4b7416b4a
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-29T22:33:29Z
rollback
commit be502953eaad33fbb27bc26100f451a02829f7d2
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-30T11:42:56Z
TAVERNA-989
commit 3d0a394e643be72372ebe6288f43a4eac9882656
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-30T14:09:01Z
TAVERNA-989 : Changed return type to Path
commit 30970c6c34e08c6abd0cd0c22aa3fcd2aced4ebb
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-30T15:31:55Z
TAVERNA-989 : changed return type to Path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-workbench/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench issue #5: Taverna 989 : Changed return type to P...
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-workbench/pull/5
Thanks! Merged.
@ThilinaManamgoda, would you be OK to close https://issues.apache.org/jira/browse/TAVERNA-989 and reference this pull request in the comments? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
Posted by ThilinaManamgoda <gi...@git.apache.org>.
Github user ThilinaManamgoda commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/5#discussion_r70269861
--- Diff: taverna-activity-palette-impl/pom.xml ---
@@ -92,7 +94,7 @@
<groupId>org.apache.taverna.osgi</groupId>
<artifactId>taverna-app-configuration-impl</artifactId>
<version>${taverna.osgi.version}</version>
- <scope>test</scope>
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
Posted by ThilinaManamgoda <gi...@git.apache.org>.
Github user ThilinaManamgoda closed the pull request at:
https://github.com/apache/incubator-taverna-workbench/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
Posted by stain <gi...@git.apache.org>.
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/5#discussion_r70263887
--- Diff: taverna-activity-palette-impl/pom.xml ---
@@ -92,7 +94,7 @@
<groupId>org.apache.taverna.osgi</groupId>
<artifactId>taverna-app-configuration-impl</artifactId>
<version>${taverna.osgi.version}</version>
- <scope>test</scope>
--- End diff --
Could you re-add this scope? I don't see that it needs a runtime dependency here, it compiles well with `<scope>test</scope>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
Posted by stain <gi...@git.apache.org>.
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/5#discussion_r70264046
--- Diff: taverna-activity-palette-impl/pom.xml ---
@@ -1,20 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!--
- Licensed to the Apache Software Foundation (ASF) under one or more
- contributor license agreements. See the NOTICE file distributed with
- this work for additional information regarding copyright ownership.
- The ASF licenses this file to You under the Apache License, Version 2.0
- (the "License"); you may not use this file except in compliance with
- the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
--->
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
--- End diff --
Could you undo the "reformatting" of this ASF header? I guess Eclipse might be the culpit.. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench issue #5: Taverna 989 : Changed return type to P...
Posted by ThilinaManamgoda <gi...@git.apache.org>.
Github user ThilinaManamgoda commented on the issue:
https://github.com/apache/incubator-taverna-workbench/pull/5
Your welcome ! . Yes i will close the pull request
On Wed, Jul 13, 2016 at 8:02 PM, Stian Soiland-Reyes <
notifications@github.com> wrote:
> Thanks! Merged.
>
> @ThilinaManamgoda <https://github.com/ThilinaManamgoda>, would you be OK
> to close https://issues.apache.org/jira/browse/TAVERNA-989 and reference
> this pull request in the comments? :)
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-taverna-workbench/pull/5#issuecomment-232373925>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/ALNHkuq_Dwqtknel1DMd7XBErHkJiNTZks5qVPcSgaJpZM4JCShW>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-workbench pull request #5: Taverna 989 : Changed return ty...
Posted by ThilinaManamgoda <gi...@git.apache.org>.
GitHub user ThilinaManamgoda reopened a pull request:
https://github.com/apache/incubator-taverna-workbench/pull/5
Taverna 989 : Changed return type to Path
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThilinaManamgoda/incubator-taverna-workbench TAVERNA-989
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-workbench/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit 4c548c8fceebba32532f0e3e068e8ea8d8136dec
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-29T22:25:48Z
testing
commit ed2ab6f13b428414ac7905a62fce14b4b7416b4a
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-29T22:33:29Z
rollback
commit be502953eaad33fbb27bc26100f451a02829f7d2
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-30T11:42:56Z
TAVERNA-989
commit 3d0a394e643be72372ebe6288f43a4eac9882656
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-30T14:09:01Z
TAVERNA-989 : Changed return type to Path
commit 30970c6c34e08c6abd0cd0c22aa3fcd2aced4ebb
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-06-30T15:31:55Z
TAVERNA-989 : changed return type to Path
commit 419d837adad9269bddd43aacd71abc6e64e355e6
Author: ThilinaManamgoda <ma...@gmail.com>
Date: 2016-07-06T17:12:38Z
TAVERNA-989 : confilct with commons-csv is resolved
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---