You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/30 20:54:03 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new issue, #6424: Refactor: implement the managesnapshot.sh features via Java and remove the script
GutoVeronezi opened a new issue, #6424:
URL: https://github.com/apache/cloudstack/issues/6424
Several snapshot functionalities, in KVM, are implemented via the script `scripts/storage/qcow2/managesnapshot.sh`. From https://github.com/apache/cloudstack/pull/6422#discussion_r884991838 came the idea to improve these processes by implementing the functionalities via Java, adding documentation, unit tests and logs.
##### ISSUE TYPE
* Improvement Request
##### COMPONENT NAME
KVM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6424: Refactor: implement the managesnapshot.sh features via Java and remove the script
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #6424:
URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-1155537946
> > Hate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc.
> > With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths? Thoughts @weizhouapache @wido @rohityadavcloud ?
>
> No, I actually think we should implement this in the Java bindings where possible, but ofcourse, caution is needed.
>
> The reason things were implemented in shell scripts is because people didn't bother in implementing it in libvirt-java and thus just took the easier route.
>
> Using the API calls of Libvirt is safer, has better Exception handling and such.
>
> Where possible, use that :-)
agree with @wido
if we can do it using libvirt-java, it is much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Refactor: implement the managesnapshot.sh features via Java and remove the script [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6424:
URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-4523869902
This issue is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on issue #6424: Refactor: implement the managesnapshot.sh features via Java and remove the script
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on issue #6424:
URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-1171949704
@GutoVeronezi are you working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Refactor: implement the managesnapshot.sh features via Java and remove the script [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #6424:
URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-3710419990
@GutoVeronezi , given that much work on snapshots has been done since, what is the status of this ticket in your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on issue #6424: Refactor: implement the managesnapshot.sh features via Java and remove the script
Posted by GitBox <gi...@apache.org>.
NuxRo commented on issue #6424:
URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-1155145372
Hate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc.
With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths?
Thoughts @weizhouapache @wido @rohityadavcloud ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on issue #6424: Refactor: implement the managesnapshot.sh features via Java and remove the script
Posted by GitBox <gi...@apache.org>.
wido commented on issue #6424:
URL: https://github.com/apache/cloudstack/issues/6424#issuecomment-1155263243
> Hate to stand in the way of progress, but I believe part of the reason Cloudstack has shell scripts in various places, particularly in dealing with libvirt is because historically the java bindings have lagged behind in functionality etc.
>
> With my Ops hat on, are we sure the shell script bits we want to replace with java are now properly supported in all the major distro, especially the older ones (eg CentOS 7, Ubuntu 20.04) or are we in danger of breaking upgrade paths? Thoughts @weizhouapache @wido @rohityadavcloud ?
No, I actually think we should implement this in the Java bindings where possible, but ofcourse, caution is needed.
The reason things were implemented in shell scripts is because people didn't bother in implementing it in libvirt-java and thus just took the easier route.
Using the API calls of Libvirt is safer, has better Exception handling and such.
Where possible, use that :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org