You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/11 22:41:20 UTC
[jira] [Commented] (ARTEMIS-794) AMQP: Modified Outcome is not
being handled correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566843#comment-15566843 ]
ASF GitHub Bot commented on ARTEMIS-794:
----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/840
ARTEMIS-794 Add tests for handling of various outcomes for deliveries
Adds tests for handling of Rejected, Released and Modified outcomes for
a delivery sent to a receiver. Tests show that for the Modified outcome
the broker is redelivering the message to the same receiver when the
undeliverable here value is set which violates the AMQP 1.0 specified
handling of that field.
Small fix included to not adjust the delivery count if the Modified
outcome does not indicate that the delivery failed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-794
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #840
----
commit cb994c8f6b55f494389bde267415104043e38f86
Author: Timothy Bish <ta...@gmail.com>
Date: 2016-10-11T22:39:46Z
ARTEMIS-794 Add tests for handling of various outcomes for deliveries
Adds tests for handling of Rejected, Released and Modified outcomes for
a delivery sent to a receiver. Tests show that for the Modified outcome
the broker is redelivering the message to the same receiver when the
undeliverable here value is set which violates the AMQP 1.0 specified
handling of that field.
Small fix included to not adjust the delivery count if the Modified
outcome does not indicate that the delivery failed.
----
> AMQP: Modified Outcome is not being handled correctly
> -----------------------------------------------------
>
> Key: ARTEMIS-794
> URL: https://issues.apache.org/jira/browse/ARTEMIS-794
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: AMQP
> Affects Versions: 1.4.0
> Reporter: Timothy Bish
>
> The Modified outcome when sent has certain constraints placed on how the broker should handle it. If the outcome indicates the delivery failed the remote must increment the delivery count, otherwise it should not. If the outcome indicates that the message is "undeliverable here" than the remote must not send the message back to the modifying link.
> (Note that in 5.x we treat the undeliverable here value as a cause to DLQ the message in order to ensure we don't redeliver it again to the link that modified it)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)