Usage of default values in start scripts

[Felix Schumacher <fe...@internetallee.de>]

A recent change (r1820380) reminds me of an issue I have with the start 
scripts. I don't think it is a good idea to hardcode user-changeable 
values in the start scripts. The user will have to edit the script each 
time we ship a new version.

In tomcat we source in a env.sh (env.bat) from a known position in the 
filesystem where the user can set her own values. Those will override 
the default values from the start script.

Values I would like to see set in such a env.bat would include

  * JAVA_HOME/JRE_HOME
  * JMETER_OPTS
  * HEAP
  * JMETER_LANGUAGE
  * GC_ALGO
  * SYSTEM_PROPS
  * JVM_ARGS

What do you think?

  Felix

Re: Usage of default values in start scripts

[Philippe Mouawad <ph...@gmail.com>]

Hi Felix,
It 's a good idea, using it in Tomcat it was nice indeed.

Regards

On Sun, Jan 7, 2018 at 3:33 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> A recent change (r1820380) reminds me of an issue I have with the start
> scripts. I don't think it is a good idea to hardcode user-changeable values
> in the start scripts. The user will have to edit the script each time we
> ship a new version.
>
> In tomcat we source in a env.sh (env.bat) from a known position in the
> filesystem where the user can set her own values. Those will override the
> default values from the start script.
>
> Values I would like to see set in such a env.bat would include
>
>  * JAVA_HOME/JRE_HOME
>  * JMETER_OPTS
>  * HEAP
>  * JMETER_LANGUAGE
>  * GC_ALGO
>  * SYSTEM_PROPS
>  * JVM_ARGS
>
> What do you think?
>
>  Felix
>



-- 
Cordialement.
Philippe Mouawad.