Re: [PR] #14316 Use local repo commands instead of the github api for Release Drop Down population [grails-core]

["jamesfredley (via GitHub)" <gi...@apache.org>]

jamesfredley commented on code in PR #14834:
URL: https://github.com/apache/grails-core/pull/14834#discussion_r2173240667


##########
grails-gradle/docs-core/src/main/groovy/grails/doc/dropdown/SoftwareVersion.groovy:
##########
@@ -45,7 +45,11 @@ class SoftwareVersion implements Comparable<SoftwareVersion> {
                 softVersion.snapshot = new Snapshot(subparts[1..-1].join("-"))
                 return softVersion
             }
-            softVersion.patch = parts[2].toInteger()
+
+            // Filter out invalid patches (e.g. 1.0.RC4)
+            if (parts[2].isInteger()) {

Review Comment:
   Changing these old tags may be difficult since they are tied to releases.  
   
   https://github.com/apache/grails-core/releases/tag/v3.0.0.RC2
   https://github.com/apache/grails-core/releases/tag/v1.2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org