You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Jaydeep Karia (JIRA)" <ji...@apache.org> on 2017/08/07 17:05:00 UTC

[jira] [Updated] (STORM-2683) Storm UI - Topology action button error response hardcoded

     [ https://issues.apache.org/jira/browse/STORM-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaydeep Karia updated STORM-2683:
---------------------------------
    Description: 
Right now on confirming the topology ui action buttons (https://github.com/apache/storm/blob/4966d7a69318d2ca690c47dd43466b03574e5e9e/storm-core/src/ui/public/templates/topology-page-template.html#L607) the UI behaviour is to reload the page always (https://github.com/apache/storm/blob/10d381b303c9176ede0d1260428ad61c7757e396/storm-core/src/ui/public/js/script.js#L169) and in case of an error display a hardcoded error message _"Error while communicating with Nimbus."_

While this behaviour is okay for workflows with no authorization it gets confusing when the action buttons are put behind some form of authorization. It will be much clearer to define an error message format and have the UI display the correct error message on authorization and other non-nimbus related failures. 

  was:
Right now on confirming the topology ui action buttons (https://github.com/apache/storm/blob/4966d7a69318d2ca690c47dd43466b03574e5e9e/storm-core/src/ui/public/templates/topology-page-template.html#L607) the UI behaviour is to reload the page always (https://github.com/apache/storm/blob/10d381b303c9176ede0d1260428ad61c7757e396/storm-core/src/ui/public/js/script.js#L169) and in case of an error display a hardcoded error message _"Error while communicating with Nimbus."_

While this behaviour is okay for workflows with no authorization it gets confusing when the action buttons are put behind some form of authorization. It will be much clearer to define an error message format and have the UI display the correct error message for authorization and other non-nimbus related failures. 


> Storm UI - Topology action button error response hardcoded
> ----------------------------------------------------------
>
>                 Key: STORM-2683
>                 URL: https://issues.apache.org/jira/browse/STORM-2683
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-ui
>    Affects Versions: 1.x
>            Reporter: Jaydeep Karia
>            Priority: Minor
>
> Right now on confirming the topology ui action buttons (https://github.com/apache/storm/blob/4966d7a69318d2ca690c47dd43466b03574e5e9e/storm-core/src/ui/public/templates/topology-page-template.html#L607) the UI behaviour is to reload the page always (https://github.com/apache/storm/blob/10d381b303c9176ede0d1260428ad61c7757e396/storm-core/src/ui/public/js/script.js#L169) and in case of an error display a hardcoded error message _"Error while communicating with Nimbus."_
> While this behaviour is okay for workflows with no authorization it gets confusing when the action buttons are put behind some form of authorization. It will be much clearer to define an error message format and have the UI display the correct error message on authorization and other non-nimbus related failures. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)