You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/09/07 13:07:04 UTC
[GitHub] [skywalking-php] jmjoy opened a new pull request, #9: Upgrade dependencies and improve CI.
jmjoy opened a new pull request, #9:
URL: https://github.com/apache/skywalking-php/pull/9
1. Upgrade `phper`, with macos compat.
2. Setup CI for macos, and setup cache to speed up CI.
3. Add `required_status_checks` to `.asf.yaml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] jmjoy commented on a diff in pull request #9: Support MacOS by repalce ipc-channel with socketpair, upgrade dependencies and improve CI.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on code in PR #9:
URL: https://github.com/apache/skywalking-php/pull/9#discussion_r967627426
##########
.github/workflows/rust.yml:
##########
@@ -116,7 +157,12 @@ jobs:
with:
toolchain: stable
command: test
- args: --release
+ args: --release --workspace
+
+ - name: View logs
+ if: always()
+ run: |
+ cat /tmp/*.log
Review Comment:
@kezhenxu94 Is this step correct? I want to perform this step regardless of whether the previous step is successful or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] kezhenxu94 commented on a diff in pull request #9: Upgrade dependencies and improve CI.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #9:
URL: https://github.com/apache/skywalking-php/pull/9#discussion_r964837757
##########
.asf.yaml:
##########
@@ -30,6 +30,12 @@ github:
rebase: false
protected_branches:
master:
+ required_status_checks:
+ strict: true
+ contexts:
+ - license
+ - pecl
Review Comment:
Because you have a matrix for the job pecl, you have to include the matrix variable here, like `PECL (ubuntu-20.04, 8.1, 5.0.0)`, otherwise I’d recommend to add an aggregate job just like what you did for the test matrix. Or remove the matrix considering there is only one case in that matrix.
##########
.github/workflows/rust.yml:
##########
@@ -30,13 +30,24 @@ env:
LLVM_CONFIG_PATH: llvm-config-10
jobs:
+ required:
+ needs:
+ - test
Review Comment:
You also need to check the result of the needed jobs, skipped/cancelled jobs will also make it passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] jmjoy commented on a diff in pull request #9: Upgrade dependencies and improve CI.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on code in PR #9:
URL: https://github.com/apache/skywalking-php/pull/9#discussion_r964883796
##########
.github/workflows/rust.yml:
##########
@@ -30,13 +30,24 @@ env:
LLVM_CONFIG_PATH: llvm-config-10
jobs:
+ required:
+ needs:
+ - test
Review Comment:
Thx~
##########
.asf.yaml:
##########
@@ -30,6 +30,12 @@ github:
rebase: false
protected_branches:
master:
+ required_status_checks:
+ strict: true
+ contexts:
+ - license
+ - pecl
Review Comment:
Thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] wu-sheng commented on a diff in pull request #9: Upgrade dependencies and improve CI.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9:
URL: https://github.com/apache/skywalking-php/pull/9#discussion_r964823847
##########
.asf.yaml:
##########
@@ -30,6 +30,12 @@ github:
rebase: false
protected_branches:
master:
+ required_status_checks:
+ strict: true
+ contexts:
+ - license
+ - pecl
+ - required
Review Comment:
Ping @kezhenxu94 to review the name. I am struggling with these names every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] jmjoy commented on a diff in pull request #9: Upgrade dependencies and improve CI.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on code in PR #9:
URL: https://github.com/apache/skywalking-php/pull/9#discussion_r964825104
##########
.asf.yaml:
##########
@@ -30,6 +30,12 @@ github:
rebase: false
protected_branches:
master:
+ required_status_checks:
+ strict: true
+ contexts:
+ - license
+ - pecl
+ - required
Review Comment:
I am also troubled by these names. :smiling_face_with_tear:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] wu-sheng merged pull request #9: Support MacOS by repalce ipc-channel with socketpair, upgrade dependencies and improve CI.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9:
URL: https://github.com/apache/skywalking-php/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org