Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

[Mesos Reviewbot <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70508/#review214991
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70508]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 22, 2019, 4:47 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70508/
> -----------------------------------------------------------
> 
> (Updated April 22, 2019, 4:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Meng Zhu.
> 
> 
> Bugs: MESOS-5804
>     https://issues.apache.org/jira/browse/MESOS-5804
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test failed in MESOS-5804 due to the following race:
> 
>   1. Framework launches task T, moves from RESERVED to
>      TASK_RUNNING state.
>   2. Allocation cycle triggers and will send the unreserved
>      resources to the framework.
>   3. Before the offer gets to the framework, task T finishes and
>      framework moves from TASK_RUNNING to RESERVED.
>   4. In the RESERVED state, the framework expects the reservation
>      in the offer. But, it's coming in a later offer, and the one
>      that arrives is for the unreserved resources since it was
>      generated while the task was still running.
> 
> Tne fix applied here for this specific race is to use a 2 week
> filter rather than a 0 second filter. That would ensure that the
> unreserved resources do not get re-offered to the framework on
> their own. However, this fix does not work until MESOS-9616 is
> resolved.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp f9c7dfe46a1e8dd1bc8eae45ed1b65b7a6d60dfc 
> 
> 
> Diff: https://reviews.apache.org/r/70508/diff/1/
> 
> 
> Testing
> -------
> 
> Test passes with https://reviews.apache.org/r/70132/ applied.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>