You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/04/14 20:14:12 UTC
[GitHub] [maven-release] cstamas opened a new pull request, #181: [MRELEASE-1103] Wrong file path used for master pw file
cstamas opened a new pull request, #181:
URL: https://github.com/apache/maven-release/pull/181
Using plexus default, that is NOT same as Maven default.
---
https://issues.apache.org/jira/browse/MRELEASE-1103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] olamy commented on a diff in pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #181:
URL: https://github.com/apache/maven-release/pull/181#discussion_r1167816763
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/MavenCrypto.java:
##########
@@ -63,6 +63,9 @@ private MavenCryptoException(String message, Throwable cause) {
public MavenCrypto(DefaultSecDispatcher secDispatcher, PlexusCipher plexusCipher) {
this.secDispatcher = secDispatcher;
this.plexusCipher = plexusCipher;
+
+ // Adjust the default path (def path != maven path)
+ this.secDispatcher.setConfigurationFile("~/.m2/settings-security.xml");
Review Comment:
ditto. I wish Java could do it as well :)
well maybe a comment as it is not very intuitive. Image when some archeologists will have a look at this code with the new Maven dependencies cleanup in few years
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] cstamas commented on pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #181:
URL: https://github.com/apache/maven-release/pull/181#issuecomment-1509265035
Interesting: branch has 4 commits, but this PR shows only 3 of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] asfgit closed pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
URL: https://github.com/apache/maven-release/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] slawekjaranowski commented on pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #181:
URL: https://github.com/apache/maven-release/pull/181#issuecomment-1509860692
There is next place where we copy code and have many implementations for the same things ...
Eg in MavenCli we do similar ...
We can think about dedicated service for decryption/encryption which can use more secure system keychains or external crypto devices - but it is another topic ... I'm not an export on it ... 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] olamy commented on a diff in pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #181:
URL: https://github.com/apache/maven-release/pull/181#discussion_r1167797158
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/MavenCrypto.java:
##########
@@ -63,6 +63,9 @@ private MavenCryptoException(String message, Throwable cause) {
public MavenCrypto(DefaultSecDispatcher secDispatcher, PlexusCipher plexusCipher) {
this.secDispatcher = secDispatcher;
this.plexusCipher = plexusCipher;
+
+ // Adjust the default path (def path != maven path)
+ this.secDispatcher.setConfigurationFile("~/.m2/settings-security.xml");
Review Comment:
Does this work? I'm not sure. Windows and even on unix system?
It would be better to use something such `System.getProperty("user.home")+"/.m2/settings-security.xml"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] cstamas commented on pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #181:
URL: https://github.com/apache/maven-release/pull/181#issuecomment-1509851640
@slawekjaranowski ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #181:
URL: https://github.com/apache/maven-release/pull/181#discussion_r1167797954
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/MavenCrypto.java:
##########
@@ -63,6 +63,9 @@ private MavenCryptoException(String message, Throwable cause) {
public MavenCrypto(DefaultSecDispatcher secDispatcher, PlexusCipher plexusCipher) {
this.secDispatcher = secDispatcher;
this.plexusCipher = plexusCipher;
+
+ // Adjust the default path (def path != maven path)
+ this.secDispatcher.setConfigurationFile("~/.m2/settings-security.xml");
Review Comment:
https://github.com/codehaus-plexus/plexus-sec-dispatcher/blob/0e1eefd2eefcee9cfbd9a8fdca22e01cfe3ead55/src/main/java/org/sonatype/plexus/components/sec/dispatcher/DefaultSecDispatcher.java#L224-L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #181:
URL: https://github.com/apache/maven-release/pull/181#discussion_r1167797460
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/MavenCrypto.java:
##########
@@ -63,6 +63,9 @@ private MavenCryptoException(String message, Throwable cause) {
public MavenCrypto(DefaultSecDispatcher secDispatcher, PlexusCipher plexusCipher) {
this.secDispatcher = secDispatcher;
this.plexusCipher = plexusCipher;
+
+ // Adjust the default path (def path != maven path)
+ this.secDispatcher.setConfigurationFile("~/.m2/settings-security.xml");
Review Comment:
It does, sec dispatcher resolves this for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org