You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/10/04 08:36:29 UTC
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1222
[FLINK-2798] Serve static files for the new web frontend from the classloader
This pull request is based on https://github.com/apache/flink/pull/1202.
In order to make the new web interface run on YARN, I changed the way how static files are loaded: They are now loaded using the classloader.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink2798-second
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1222
----
commit 5a88d5ed511f67b8b41c44789e13d58cc46c03a5
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-09-25T09:44:53Z
[tests] Add HttpTestClient for testing HTTP responses
commit 656d6d610842682ed69b36a4b9109eff7c257817
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-09-25T09:47:30Z
Split WebMonitor and LeaderRetrievalService start up
commit a7e8da82a4188e6b2861f15c6f313ac672bab958
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-09-25T10:31:00Z
Move generated /web files to src/main/resources
commit 999ddb44990eee9f6a753b6635e7662074db121b
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-09-27T11:29:21Z
[dashboard] Redirect to leader in non-standalone mode
commit 3c70666043dc36b8a300b7edc791137a1ed0542e
Author: Robert Metzger <rm...@apache.org>
Date: 2015-10-02T13:37:46Z
[FLINK-2798] Enable new web interface also on YARN
commit 3323fa5ba5d0423938f85dcec9700febfbe46bf6
Author: Robert Metzger <rm...@apache.org>
Date: 2015-10-02T14:11:23Z
make all request paths relative
commit 777e73c4851206210419bb63a01e0fd04db271ad
Author: Robert Metzger <rm...@apache.org>
Date: 2015-10-02T15:41:50Z
Change YARN tests for the new web interface
commit 1ddb6c49e56ea32afc57d14a0157ba96bcb81b8e
Author: Robert Metzger <rm...@apache.org>
Date: 2015-10-04T06:31:30Z
wip
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1222#issuecomment-145488471
I gave some comments on the commit.
Looks mainly good, I am only confused why you changed all request URLs to relative from absolute. This may have other implications. If it is just to get rid of a "slash" in when creating the file path, you should probably rather prune repeated slashes instead...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1222#issuecomment-145733149
Thank you for the review. I'm trying to update the PR within the next 24 hours
Sorry for not explaining why I changed all the request URLs to relative paths: When accessing the web interface through YARN, the files are not served from the root address, but using a proxy from the RM ` http://quickstart.cloudera:8088/proxy/application_1440768826963_0005/`.
By making all request URLs relative, we can make sure everything is working as expected.
Let me know if there is a more elegant way of avoiding this.
I made a similar change to the old web interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1222#issuecomment-148369010
Max took the relevant changes from this PR into https://github.com/apache/flink/pull/1246. Closing ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1222#issuecomment-146400367
I will wait until your pull request is merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1222#issuecomment-146151414
Note: We have to check the startup logic of my changes in the YARN case as well (either in this PR or the other one).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---