You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/06/29 23:19:52 UTC

[GitHub] zeppelin pull request #2454: [ZEPPELIN-2710] Programmatically update progres...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/2454

    [ZEPPELIN-2710] Programmatically update progress bar

    ### What is this PR for?
    This PR adds setProgress(n) method to InterpreterContext.
    So user can simply update progress bar manually in the code.
    
    This can be useful when user runs some loops that takes lots of time (e.g. training) and user want to display progress with progress bar.
    
    ### What type of PR is it?
    Feature
    
    ### Todos
    * [x] - add setProgress() method
    * [ ] - Unittest
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2710
    
    ### How should this be tested?
    run following example and see if progress bar is updating
    ```
    %python
    import time
    
    ic = z.getInterpreterContext()
    
    for i in range(0, 100):
        time.sleep(0.05)
        ic.setProgress(i)
    ```
    
    ### Screenshots (if appropriate)
    ![zeppelin_progress](https://user-images.githubusercontent.com/1540981/27714525-5ac8b7c2-5d6c-11e7-91dd-d383ec9295ec.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin manual_progress_update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2454
    
----
commit 777f085e93be91f099fb1fbf6450f0dac3d7fae4
Author: Lee moon soo <mo...@apache.org>
Date:   2017-06-29T21:56:06Z

    Add setProgress method to InterpreterContext

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2454: [ZEPPELIN-2710] Programmatically update progres...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:

    https://github.com/apache/zeppelin/pull/2454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2454: [ZEPPELIN-2710] Programmatically update progres...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2454: [ZEPPELIN-2710] Programmatically update progress bar

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2454
  
    Merge to master if no further comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2454: [ZEPPELIN-2710] Programmatically update progres...

Posted by Leemoonsoo <gi...@git.apache.org>.
GitHub user Leemoonsoo reopened a pull request:

    https://github.com/apache/zeppelin/pull/2454

    [ZEPPELIN-2710] Programmatically update progress bar

    ### What is this PR for?
    This PR adds setProgress(n) method to InterpreterContext.
    So user can simply update progress bar manually in the code.
    
    This can be useful when user runs some loops that takes lots of time (e.g. training) and user want to display progress with progress bar.
    
    ### What type of PR is it?
    Feature
    
    ### Todos
    * [x] - add setProgress() method
    * [x] - Unittest
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2710
    
    ### How should this be tested?
    run following example and see if progress bar is updating
    ```
    %python
    import time
    
    ic = z.getInterpreterContext()
    
    for i in range(0, 100):
        time.sleep(0.05)
        ic.setProgress(i)
    ```
    
    ### Screenshots (if appropriate)
    ![zeppelin_progress](https://user-images.githubusercontent.com/1540981/27714525-5ac8b7c2-5d6c-11e7-91dd-d383ec9295ec.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin manual_progress_update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2454
    
----
commit 777f085e93be91f099fb1fbf6450f0dac3d7fae4
Author: Lee moon soo <mo...@apache.org>
Date:   2017-06-29T21:56:06Z

    Add setProgress method to InterpreterContext

commit f0c813261c68053921238db1b20f40a56685bb7c
Author: Lee moon soo <mo...@apache.org>
Date:   2017-06-29T23:55:04Z

    Add unittest for setProgress

commit 592f97a8ce9a35c310fefc4a47296c195371ae4e
Author: Lee moon soo <mo...@apache.org>
Date:   2017-06-30T00:20:43Z

    Remove unnecessary print

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---