You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/08/27 11:51:45 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #15626: [Unity] Implement relax.Function.bind_params

Lunderberg opened a new pull request, #15626:
URL: https://github.com/apache/tvm/pull/15626

   Similar to `relax.Function.bind_symbolic_vars`, implemented in https://github.com/apache/tvm/pull/15509, this commit introduces `relax.Function.bind_params` to allow Relax parameters to be manipulated on a per-function basis.  This utility function and the existing `BindParams` transform both use the same underlying implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #15626: [Unity] Implement relax.Function.bind_params

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.

Lunderberg commented on PR #15626:
URL: https://github.com/apache/tvm/pull/15626#issuecomment-1698321539

   At the moment, this would primarily be to write a single Relax function, then manually manipulate it into a specialized form.  For example, writing an attention function that accepts a boolean filter tensor, then using BindParams to make a sibling function that replaces it with a constant tensor which o Lu contains `True`.
   
   In the past, this would have been used to statically bind model parameters into an end-to-end model.  However, since that requires the compiling machine to have sufficient RAM, it isn’t as flexible as the `LiftTransformParams`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] csullivan commented on pull request #15626: [Unity] Implement relax.Function.bind_params

Posted by "csullivan (via GitHub)" <gi...@apache.org>.

csullivan commented on PR #15626:
URL: https://github.com/apache/tvm/pull/15626#issuecomment-1708960891

   Thanks @Lunderberg and @sunggg! This is merged. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] csullivan merged pull request #15626: [Unity] Implement relax.Function.bind_params

Posted by "csullivan (via GitHub)" <gi...@apache.org>.

csullivan merged PR #15626:
URL: https://github.com/apache/tvm/pull/15626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #15626: [Unity] Implement relax.Function.bind_params

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.

Lunderberg commented on PR #15626:
URL: https://github.com/apache/tvm/pull/15626#issuecomment-1694647874

   @sunggg This is a follow-up to the `BindSymbolicVars` commit we made a few weeks ago.  Since `BindSymbolicVars` and `BindParams` are so similar, I wanted to have the same functionality for both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15626: [Unity] Implement relax.Function.bind_params

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.

tvm-bot commented on PR #15626:
URL: https://github.com/apache/tvm/pull/15626#issuecomment-1694647358

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org