You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "morristai (via GitHub)" <gi...@apache.org> on 2023/05/14 03:54:24 UTC
[GitHub] [incubator-opendal] morristai opened a new issue, #2261: Unnecessary Path Prefix?
morristai opened a new issue, #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261
I noticed there are some duplicated path prefixes being imported. Is this done for better readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2261: Unnecessary Path Prefix?
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261#issuecomment-1549768321
> Sure. I'll work on this one.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] silver-ymz commented on issue #2261: Unnecessary Path Prefix?
Posted by "silver-ymz (via GitHub)" <gi...@apache.org>.
silver-ymz commented on issue #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261#issuecomment-1547177636
I think this is used to distinguish between `tokio::fs::File` and `std::fs::File`. For non-blocking operations, we use `tokio::fs::File`, and `std::fs::File` for blocking one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo closed issue #2261: Unnecessary Path Prefix?
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #2261: Unnecessary Path Prefix?
URL: https://github.com/apache/incubator-opendal/issues/2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2261: Unnecessary Path Prefix?
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261#issuecomment-1549734457
It's a mistake that `tokio::fs` been imported, it's better to remove it. Do you want to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] morristai commented on issue #2261: Unnecessary Path Prefix?
Posted by "morristai (via GitHub)" <gi...@apache.org>.
morristai commented on issue #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261#issuecomment-1548371743
I understand, but since the file already imports `tokio::fs` from the beginning, and the Rust compiler doesn't allow the same name to be defined multiple times, would it be fine to just call `fs::File` instead of `tokio::fs::File`? I just want to know what the recommended practice is here. If this issue doesn't seem to bother you, I'll close it.
<img width="598" alt="image" src="https://github.com/apache/incubator-opendal/assets/10728152/dbb8d172-1047-457d-bbc6-ffea904d3ff4">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] morristai commented on issue #2261: Unnecessary Path Prefix?
Posted by "morristai (via GitHub)" <gi...@apache.org>.
morristai commented on issue #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261#issuecomment-1549758921
> It's a mistake that `tokio::fs` been imported, it's better to remove it. Do you want to do this?
Sure. I'll work on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2261: Unnecessary Path Prefix?
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2261:
URL: https://github.com/apache/incubator-opendal/issues/2261#issuecomment-1550706277
Fixed by https://github.com/apache/incubator-opendal/pull/2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org