You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by dj...@apache.org on 2005/09/24 06:00:19 UTC
svn commit: r291242 -
/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Author: djencks
Date: Fri Sep 23 21:00:15 2005
New Revision: 291242
URL: http://svn.apache.org/viewcvs?rev=291242&view=rev
Log:
Make LocalAttributeManager output a more reasonable logging volume
Modified:
geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Modified: geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
URL: http://svn.apache.org/viewcvs/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java?rev=291242&r1=291241&r2=291242&view=diff
==============================================================================
--- geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java (original)
+++ geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java Fri Sep 23 21:00:15 2005
@@ -84,7 +84,6 @@
}
public Object getValue(String configurationName, ObjectName gbean, GAttributeInfo attribute) {
- log.debug("Checking value for "+configurationName+"/"+gbean+"/"+attribute.getName());
Map config = (Map) configurations.get(configurationName);
if(config == null) {
return null; // nothing specified for this configuration
@@ -103,11 +102,11 @@
try {
PropertyEditor editor = PropertyEditors.findEditor(attribute.getType(), getClass().getClassLoader());
if (editor == null) {
- log.error("Unable to parse attribute of type "+attribute.getType()+"; no editor found");
+ log.debug("Unable to parse attribute of type "+attribute.getType()+"; no editor found");
return null;
}
editor.setAsText(value);
- log.info("Setting value for "+configurationName+"/"+gbean+"/" + attribute.getName() + " to value " + value);
+ log.debug("Setting value for "+configurationName+"/"+gbean+"/" + attribute.getName() + " to value " + value);
return editor.getValue();
} catch (ClassNotFoundException e) {
//todo: use the Configuration's ClassLoader to load the attribute, if this ever becomes an issue
Re: svn commit: r291242 - /geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
I dunno, I think it might merit more than a DEBUG if you try to store
a property that can't be stored.
Aaron
On 9/24/05, djencks@apache.org <dj...@apache.org> wrote:
> Author: djencks
> Date: Fri Sep 23 21:00:15 2005
> New Revision: 291242
>
> URL: http://svn.apache.org/viewcvs?rev=291242&view=rev
> Log:
> Make LocalAttributeManager output a more reasonable logging volume
>
> Modified:
> geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
>
> Modified: geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
> URL: http://svn.apache.org/viewcvs/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java?rev=291242&r1=291241&r2=291242&view=diff
> ==============================================================================
> --- geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java (original)
> +++ geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java Fri Sep 23 21:00:15 2005
> @@ -84,7 +84,6 @@
> }
>
> public Object getValue(String configurationName, ObjectName gbean, GAttributeInfo attribute) {
> - log.debug("Checking value for "+configurationName+"/"+gbean+"/"+attribute.getName());
> Map config = (Map) configurations.get(configurationName);
> if(config == null) {
> return null; // nothing specified for this configuration
> @@ -103,11 +102,11 @@
> try {
> PropertyEditor editor = PropertyEditors.findEditor(attribute.getType(), getClass().getClassLoader());
> if (editor == null) {
> - log.error("Unable to parse attribute of type "+attribute.getType()+"; no editor found");
> + log.debug("Unable to parse attribute of type "+attribute.getType()+"; no editor found");
> return null;
> }
> editor.setAsText(value);
> - log.info("Setting value for "+configurationName+"/"+gbean+"/" + attribute.getName() + " to value " + value);
> + log.debug("Setting value for "+configurationName+"/"+gbean+"/" + attribute.getName() + " to value " + value);
> return editor.getValue();
> } catch (ClassNotFoundException e) {
> //todo: use the Configuration's ClassLoader to load the attribute, if this ever becomes an issue
>
>
>