[GitHub] rawlinp commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242304062
 
 

 ##########
 File path: docs/source/development/traffic_ops.rst
 ##########
 @@ -229,30 +229,11 @@ To install the Traffic Ops Developer environment:
 	.. seealso:: `PostgreSQL instructions on setting up a database <https://wiki.postgresql.org/wiki/First_steps>`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database Management`_ for usage) to set up the traffic_ops database(s).
-
-	 Example Output::
-
-		$ db/admin.pl --env=development setup
-		Using database.conf: conf/development/database.conf
-		Using database.conf: conf/development/database.conf
-		Using database.conf: conf/development/database.conf
-		Using database.conf: conf/development/database.conf
-		Using database.conf: conf/development/database.conf
-		Using database.conf: conf/development/database.conf
-		Executing 'drop database to_development'
-		Executing 'create database to_development'
-		Creating database tables...
-		Warning: Using a password on the command line interface can be insecure.
-		Migrating database...
-		goose: migrating db environment 'development', current version: 0, target: 20150210100000
-		OK    20141222103718_extension.sql
-		OK    20150108100000_add_job_deliveryservice.sql
-		OK    20150205100000_cg_location.sql
-		OK    20150209100000_cran_to_asn.sql
-		OK    20150210100000_ds_keyinfo.sql
-		Seeding database...
-		Warning: Using a password on the command line interface can be insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see `Database Management`_ for usage) to set up the traffic_ops database(s).
+
+	 Example Usage::
 
 Review comment:
   So, I made this change, but if you check the built html, everything on this page that is contained in the `.. code-block` syntax doesn't even show up in the doc at all. For example, there is a long list of Perltidy options that are in the rst but don't show up in the built html (it's using `.. code-block::perl` syntax): https://traffic-control-cdn.readthedocs.io/en/latest/development/traffic_ops.html#perl-formatting-conventions
   Any idea what's going on here? I suspect there are probably numerous other things not showing up in the docs currently because of this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services